[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1125: POC: Tcp backpressure - DO NOT MERGE!

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1125:
URL: https://github.com/apache/qpid-dispatch/pull/1125#discussion_r614251431



##########
File path: src/router_core/delivery.c
##########
@@ -712,14 +712,15 @@ static void qdr_delivery_anycast_update_CT(qdr_core_t *core, qdr_delivery_t *dlv
     //
     // Non-multicast Logic:
     //
-    // If disposition has changed and there is a peer link, set the disposition
-    // of the peer
+    // If the disposition or extended delivery-state has changed and there is a
+    // peer link, set the disposition/delivery-state of the peer
     // If remote settled, the delivery must be unlinked and freed.
     // If remote settled and there is a peer, the peer shall be settled and
     // unlinked.  It shall not be freed until the connection-side thread
     // settles the PN delivery.
     //
-    if (new_disp != dlv->remote_disposition) {
+    // kag fix me!
+    if (new_disp != dlv->remote_disposition || dlv->remote_state) {

Review comment:
       Good point - I'm going to need to refactor this a bit more.  This POC is exposing a few assumptions we've made regarding disposition propagation that need to be revisited.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org