You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/24 16:59:00 UTC
[jira] [Commented] (PHOENIX-6820) Update python-phoenixdb/RELEASING.rst
[ https://issues.apache.org/jira/browse/PHOENIX-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623291#comment-17623291 ]
ASF GitHub Bot commented on PHOENIX-6820:
-----------------------------------------
stoty commented on code in PR #111:
URL: https://github.com/apache/phoenix-queryserver/pull/111#discussion_r1003549397
##########
python-phoenixdb/RELEASING.rst:
##########
@@ -60,7 +60,10 @@ as an email template.
Publishing
----------
-#. If the vote passes, upload the package to PyPI (using the instructions linked above)
+#. If the vote passes, upload the package to PyPI (using the instructions linked above, and some extra notes here)
+ * Make sure to run the ``python setup.py sdist bdist_wheel`` with python 2 and 3 as well.
+ * To verify it you should have two ``.whl`` files under ``dist/`` folder
+ * ``pip install --index-url https://test.pypi.org/simple/ phoenixdb`` might not work for python2
Review Comment:
Add:
because the test repo tends to miss the older versions of dependencies required for Python2.
> Update python-phoenixdb/RELEASING.rst
> -------------------------------------
>
> Key: PHOENIX-6820
> URL: https://issues.apache.org/jira/browse/PHOENIX-6820
> Project: Phoenix
> Issue Type: Task
> Reporter: Richárd Antal
> Assignee: Richárd Antal
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)