You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/02/13 04:41:08 UTC
Review Request 65624: Added fetcher tests for `stderr` output.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65624/
-----------------------------------------------------------
Review request for mesos, Akash Gupta and Joseph Wu.
Repository: mesos
Description
-------
The fetcher is supposed to log its `stderr` output to a redirected file
called `stderr` in the given sandbox directory. There previously existed
a bug on Windows due to incorrect handle inheritance where this
redirection failed silently, leaving the log empty. These unit tests
assert that the correct content is logged to the `stderr` file for both
a success and failure fetch scenario.
Diffs
-----
src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f
Diff: https://reviews.apache.org/r/65624/diff/1/
Testing
-------
Windows (Linux pending):
```
[ RUN ] FetcherTest.LogSuccessToStderr
[ OK ] FetcherTest.LogSuccessToStderr (197 ms)
[ RUN ] FetcherTest.LogFailureToStderr
[ OK ] FetcherTest.LogFailureToStderr (320 ms)
```
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65624: Added fetcher tests for `stderr` output.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65624/#review197400
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65397, 65398, 65399, 65400, 65401, 65402, 65405, 65406, 65407, 65408, 65409, 65465, 65403, 65467, 65574, 65469, 65624]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 13, 2018, 4:41 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65624/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2018, 4:41 a.m.)
>
>
> Review request for mesos, Akash Gupta and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The fetcher is supposed to log its `stderr` output to a redirected file
> called `stderr` in the given sandbox directory. There previously existed
> a bug on Windows due to incorrect handle inheritance where this
> redirection failed silently, leaving the log empty. These unit tests
> assert that the correct content is logged to the `stderr` file for both
> a success and failure fetch scenario.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f
>
>
> Diff: https://reviews.apache.org/r/65624/diff/1/
>
>
> Testing
> -------
>
> Windows (Linux pending):
> ```
> [ RUN ] FetcherTest.LogSuccessToStderr
> [ OK ] FetcherTest.LogSuccessToStderr (197 ms)
> [ RUN ] FetcherTest.LogFailureToStderr
> [ OK ] FetcherTest.LogFailureToStderr (320 ms)
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65624: Added fetcher tests for `stderr` output.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65624/#review197378
-----------------------------------------------------------
PASS: Mesos patch 65624 was successfully built and tested.
Reviews applied: `['65403', '65467', '65574', '65469', '65624']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65624
- Mesos Reviewbot Windows
On Feb. 13, 2018, 4:41 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65624/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2018, 4:41 a.m.)
>
>
> Review request for mesos, Akash Gupta and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The fetcher is supposed to log its `stderr` output to a redirected file
> called `stderr` in the given sandbox directory. There previously existed
> a bug on Windows due to incorrect handle inheritance where this
> redirection failed silently, leaving the log empty. These unit tests
> assert that the correct content is logged to the `stderr` file for both
> a success and failure fetch scenario.
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f
>
>
> Diff: https://reviews.apache.org/r/65624/diff/1/
>
>
> Testing
> -------
>
> Windows (Linux pending):
> ```
> [ RUN ] FetcherTest.LogSuccessToStderr
> [ OK ] FetcherTest.LogSuccessToStderr (197 ms)
> [ RUN ] FetcherTest.LogFailureToStderr
> [ OK ] FetcherTest.LogFailureToStderr (320 ms)
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>