You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/07 23:48:46 UTC
[GitHub] [superset] hughhhh opened a new pull request #15580: chore: upgrading dependencies for superset
hughhhh opened a new pull request #15580:
URL: https://github.com/apache/superset/pull/15580
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15580: chore: upgrading dependencies for superset
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15580:
URL: https://github.com/apache/superset/pull/15580#issuecomment-876027307
# [Codecov](https://codecov.io/gh/apache/superset/pull/15580?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15580](https://codecov.io/gh/apache/superset/pull/15580?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1df058d) into [master](https://codecov.io/gh/apache/superset/commit/ae160f7f2137eb3334eed13682db886498fe0db9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae160f7) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/15580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15580 +/- ##
=======================================
Coverage 76.87% 76.87%
=======================================
Files 976 976
Lines 51293 51293
Branches 6907 6907
=======================================
Hits 39431 39431
Misses 11643 11643
Partials 219 219
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.42% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15580?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15580?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ae160f7...1df058d](https://codecov.io/gh/apache/superset/pull/15580?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh closed pull request #15580: chore: upgrading dependencies for superset
Posted by GitBox <gi...@apache.org>.
hughhhh closed pull request #15580:
URL: https://github.com/apache/superset/pull/15580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a change in pull request #15580: chore: upgrading dependencies for superset
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #15580:
URL: https://github.com/apache/superset/pull/15580#discussion_r671608870
##########
File path: requirements/base.in
##########
@@ -18,3 +18,7 @@
-e file:.
pyrsistent>=0.16.1,<0.17
zipp==3.4.1
+click
+py>=1.10.0
+urllib3>=1.26.5
Review comment:
I'm not clear why this included here and not in `setup.py`. Also [this](https://github.com/apache/superset/blob/9773aba522e957ed9423045ca153219638a85d2f/superset/db_engine_specs/clickhouse.py#L51) non-top level import of `urllib3` seems weird.
##########
File path: requirements/base.in
##########
@@ -18,3 +18,7 @@
-e file:.
pyrsistent>=0.16.1,<0.17
zipp==3.4.1
+click
+py>=1.10.0
+urllib3>=1.26.5
+aiohttp>=3.7.4
Review comment:
Is this used anywhere? It's not evident per [this](https://github.com/apache/superset/search?q=aiohttp) search.
##########
File path: requirements/base.in
##########
@@ -18,3 +18,7 @@
-e file:.
pyrsistent>=0.16.1,<0.17
zipp==3.4.1
+click
Review comment:
This is already defined in `setup.py`. It'll be pulled in via line #18.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org