You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Simon Kitching <si...@chello.at> on 2008/01/03 13:29:52 UTC

Re: svn commit: r608426 - /myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/application/DefaultViewHandlerSupport.java

Hi Mario,

This commit has introduced tabs throughout the file. I *think* the convention in myfaces is to use 4 spaces for indenting, rather than tabs.

In particular, these tabs render as 8 spaces in command-line tools, diffs, and some people's editors.

Cheers,  Simon

---- imario@apache.org schrieb:
> Author: imario
> Date: Thu Jan  3 02:40:24 2008
> New Revision: 608426
> 
> URL: http://svn.apache.org/viewvc?rev=608426&view=rev
> Log:
> reformat code
> 
> Modified:
>     myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/application/DefaultViewHandlerSupport.java
> 
> Modified: myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/application/DefaultViewHandlerSupport.java
> URL: http://svn.apache.org/viewvc/myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/application/DefaultViewHandlerSupport.java?rev=608426&r1=608425&r2=608426&view=diff
> 



Re: svn commit: r608426 - /myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/application/DefaultViewHandlerSupport.java

Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi!
> This commit has introduced tabs throughout the file. I *think* the convention in myfaces is to use 4 spaces for indenting, rather than tabs.
>
> In particular, these tabs render as 8 spaces in command-line tools, diffs, and some people's editors.
>   
Ok, will check my IDE, just, it is not my top priority as I struggle 
around with other (MyFaces) things preventing me from making progress 
with my day job. I am anything else then happy at the moment.

BTW: Did you notice that tomahawk does not build at the moment due to 
JDK 1.6 code you introduced :-) Just as a tip ;-)

Ciao,
Mario