You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2024/04/10 16:06:06 UTC
[PR] AMQ-9475 - ConsumerControl commands should not auto create wildcard dests [activemq]
cshannon opened a new pull request, #1200:
URL: https://github.com/apache/activemq/pull/1200
This fixes an issue where wildcard destinations could be inadvertently created by ConsumerControl commands which could lead to problems. The processing logic for this command now will only look up existing destinations if they exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AMQ-9475 - ConsumerControl commands should not auto create wildcard dests [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon merged PR #1200:
URL: https://github.com/apache/activemq/pull/1200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AMQ-9475 - ConsumerControl commands should not auto create wildcard dests [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1200:
URL: https://github.com/apache/activemq/pull/1200#issuecomment-2048023988
I'll let the tests finish and then I'll merge and backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AMQ-9475 - ConsumerControl commands should not auto create wildcard dests [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1200:
URL: https://github.com/apache/activemq/pull/1200#issuecomment-2048048719
> @cshannon @mattrpav I rebuilt ActiveMQ with these changes and can confirm that wildcard topics are no longer created and everything works as expected.
>
> Thank you.
Thanks for the quick test, glad that worked for you. This will be included in the next bug fix releases for 6.1.x and 5.18.x. 5.18.4 is already under vote so this will be in 5.18.5 but obviously you can just build your own version as you did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AMQ-9475 - ConsumerControl commands should not auto create wildcard dests [activemq]
Posted by "thezbyg (via GitHub)" <gi...@apache.org>.
thezbyg commented on PR #1200:
URL: https://github.com/apache/activemq/pull/1200#issuecomment-2048044907
@cshannon @mattrpav I rebuilt ActiveMQ with these changes and can confirm that wildcard topics are no longer created and everything works as expected.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org