You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/18 14:06:11 UTC
[GitHub] [arrow-rs] thinkharderdev opened a new pull request, #2100: Support skip_values in DictionaryDecoder
thinkharderdev opened a new pull request, #2100:
URL: https://github.com/apache/arrow-rs/pull/2100
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2079
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2100: Support skip_values in DictionaryDecoder
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2100:
URL: https://github.com/apache/arrow-rs/pull/2100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2100: Support skip_values in DictionaryDecoder
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2100:
URL: https://github.com/apache/arrow-rs/pull/2100#discussion_r923627094
##########
parquet/src/arrow/array_reader/byte_array_dictionary.rs:
##########
@@ -507,6 +519,51 @@ mod tests {
}
}
+ #[test]
+ fn test_dictionary_skip_fallback() {
+ let data_type = utf8_dictionary();
+ let data = vec!["hello", "world", "a", "b"];
+
+ let (pages, encoded_dictionary) = byte_array_all_encodings(data.clone());
+ let num_encodings = pages.len();
+
+ let column_desc = utf8_column();
+ let mut decoder = DictionaryDecoder::<i32, i32>::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ // Read all pages into single buffer
+ let mut output = DictionaryBuffer::<i32, i32>::default();
+
+ for (encoding, page) in pages {
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+ decoder.skip_values(2).expect("skipping two values");
+ assert_eq!(decoder.read(&mut output, 0..1024).unwrap(), 2);
+ }
+ let array = output.into_array(None, &data_type).unwrap();
+ assert_eq!(array.data_type(), &data_type);
+
+ let array = cast(&array, &ArrowType::Utf8).unwrap();
+ let strings = array.as_any().downcast_ref::<StringArray>().unwrap();
+ assert_eq!(strings.len(), (data.len() - 2) * num_encodings);
+
+ // Should have a copy of `data` for each encoding
+ for i in 0..num_encodings {
+ assert_eq!(
+ &strings
+ .iter()
+ .skip(i * (data.len() - 2))
Review Comment:
Actually nvm - remembered how this test worked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2100: Support skip_values in DictionaryDecoder
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2100:
URL: https://github.com/apache/arrow-rs/pull/2100#discussion_r923612719
##########
parquet/src/arrow/array_reader/byte_array_dictionary.rs:
##########
@@ -507,6 +519,51 @@ mod tests {
}
}
+ #[test]
+ fn test_dictionary_skip_fallback() {
+ let data_type = utf8_dictionary();
+ let data = vec!["hello", "world", "a", "b"];
+
+ let (pages, encoded_dictionary) = byte_array_all_encodings(data.clone());
+ let num_encodings = pages.len();
+
+ let column_desc = utf8_column();
+ let mut decoder = DictionaryDecoder::<i32, i32>::new(&column_desc);
+
+ decoder
+ .set_dict(encoded_dictionary, 4, Encoding::RLE_DICTIONARY, false)
+ .unwrap();
+
+ // Read all pages into single buffer
+ let mut output = DictionaryBuffer::<i32, i32>::default();
+
+ for (encoding, page) in pages {
+ decoder.set_data(encoding, page, 4, Some(4)).unwrap();
+ decoder.skip_values(2).expect("skipping two values");
+ assert_eq!(decoder.read(&mut output, 0..1024).unwrap(), 2);
+ }
+ let array = output.into_array(None, &data_type).unwrap();
+ assert_eq!(array.data_type(), &data_type);
+
+ let array = cast(&array, &ArrowType::Utf8).unwrap();
+ let strings = array.as_any().downcast_ref::<StringArray>().unwrap();
+ assert_eq!(strings.len(), (data.len() - 2) * num_encodings);
+
+ // Should have a copy of `data` for each encoding
+ for i in 0..num_encodings {
+ assert_eq!(
+ &strings
+ .iter()
+ .skip(i * (data.len() - 2))
Review Comment:
```suggestion
.skip(i * 2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2100: Support skip_values in DictionaryDecoder
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2100:
URL: https://github.com/apache/arrow-rs/pull/2100#issuecomment-1187835125
Benchmark runs are scheduled for baseline = 53e9388f27be12e8355d5e12c9c4c9e1b8ea772e and contender = 7b3d0628859fa9349522a0e3274e5011cf2a8b06. 7b3d0628859fa9349522a0e3274e5011cf2a8b06 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f34edf12b9a440efb51a1ffa1d318026...e70e2150ca1d40bbbb569655bdf520cf/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/49f18c2e7e31466fb5763db3148fec01...72e794561942410b960b104869e15008/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1631ac21575a4a69ba1c5dacc2a857e2...8fb9d5826b9d4d34997bfcbe6686b1fb/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fee2d349abc14b39bcd1e2c13eec8684...7e2fbcbf9f924d289b62ce87ca8368d6/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org