[jira] [Commented] (YARN-5694) ZKRMStateStore should only start its verification thread when in HA failover is not embedded

["Karthik Kambatla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546413#comment-15546413 ] 

Karthik Kambatla commented on YARN-5694:
----------------------------------------

We should probably check for isAutoFailoverEnabledAndEmbedded?

I filed YARN-5709 to clean up surrounding code. Please feel free to pick that up. 

> ZKRMStateStore should only start its verification thread when in HA failover is not embedded
> --------------------------------------------------------------------------------------------
>
>                 Key: YARN-5694
>                 URL: https://issues.apache.org/jira/browse/YARN-5694
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: YARN-5694.001.patch, YARN-5694.branch-2.7.001.patch
>
>
> There are two cases.  In branch-2.7, the {{ZKRMStateStore.VerifyActiveStatusThread}} is always started, even when using embedded or Curator failover.  In branch-2.8, the {{ZKRMStateStore.VerifyActiveStatusThread}} is only started when HA is disabled, which makes no sense.  Based on the JIRA that introduced that change (YARN-4559), I believe the intent was to start it only when embedded failover is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org