svn commit: r1405369 - in /lucene/dev/branches/branch_4x: ./ lucene/ lucene/queries/ lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java

[mi...@apache.org]

Author: mikemccand
Date: Sat Nov  3 15:49:07 2012
New Revision: 1405369

URL: http://svn.apache.org/viewvc?rev=1405369&view=rev
Log:
add TODOs

Modified:
    lucene/dev/branches/branch_4x/   (props changed)
    lucene/dev/branches/branch_4x/lucene/   (props changed)
    lucene/dev/branches/branch_4x/lucene/queries/   (props changed)
    lucene/dev/branches/branch_4x/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java

Modified: lucene/dev/branches/branch_4x/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java?rev=1405369&r1=1405368&r2=1405369&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java (original)
+++ lucene/dev/branches/branch_4x/lucene/queries/src/java/org/apache/lucene/queries/TermsFilter.java Sat Nov  3 15:49:07 2012
@@ -114,6 +114,16 @@ public final class TermsFilter extends F
   
   
   private TermsFilter(FieldAndTermEnum iter, int length) {
+    // TODO: maybe use oal.index.PrefixCodedTerms instead?
+    // If number of terms is more than a few hundred it
+    // should be a win
+
+    // TODO: we also pack terms in FieldCache/DocValues
+    // ... maybe we can refactor to share that code
+
+    // TODO: yet another option is to build the union of the terms in
+    // an automaton an call intersect on the termsenum if the density is high
+
     int hash = 9;
     byte[] serializedTerms = new byte[0];
     this.offsets = new int[length+1];
@@ -199,10 +209,6 @@ public final class TermsFilter extends F
         }
       }
     }
-    /*
-     * TODO: we should explore if it is worth to build the union of the terms in
-     * an automaton an call intersect on the termsenum if the density is high
-     */
     return result;
   }