You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "David Primmer (JIRA)" <ji...@apache.org> on 2008/05/23 02:53:57 UTC
[jira] Created: (SHINDIG-303) move param validity checking to an
abdera filter.
move param validity checking to an abdera filter.
-------------------------------------------------
Key: SHINDIG-303
URL: https://issues.apache.org/jira/browse/SHINDIG-303
Project: Shindig
Issue Type: Improvement
Reporter: David Primmer
Attachments: shindig-303_move_param_checking_to_filter.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-303) move param validity checking to an
abdera filter.
Posted by "David Primmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Primmer updated SHINDIG-303:
----------------------------------
Attachment: shindig-303_move_param_checking_to_filter.patch
> move param validity checking to an abdera filter.
> -------------------------------------------------
>
> Key: SHINDIG-303
> URL: https://issues.apache.org/jira/browse/SHINDIG-303
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Attachments: shindig-303_move_param_checking_to_filter.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-303) move param validity checking to an
abdera filter.
Posted by "David Primmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599432#action_12599432 ]
David Primmer commented on SHINDIG-303:
---------------------------------------
Sorry about that. The patch was on top of another patch and I had a hard time with the diff. All the things you did, I thought were in there. As far as putting the attribute in the RequestContext, I just did that because it was there. It's actually slightly more verbose to get the value from the request attribute rather than just getting it from the param again so I left the code the same that does that. Sorry for the confusion.
> move param validity checking to an abdera filter.
> -------------------------------------------------
>
> Key: SHINDIG-303
> URL: https://issues.apache.org/jira/browse/SHINDIG-303
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Assignee: Cassie Doll
> Attachments: shindig-303_move_param_checking_to_filter.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-303) move param validity checking to an
abdera filter.
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599357#action_12599357 ]
Cassie Doll commented on SHINDIG-303:
-------------------------------------
This patch had some weird issues which I fixed up (I feel like maybe you forgot some things in the patch?):
1. AbstractSocialEntityCollectionAdapter was still referencing the Format enum which was moved. I changed the reference and had it get the format value from the new class.
2. I also changed the JSONWriter to use the new class so that all of the logic is just in that one valid request filter.
2. ValidRequestTest overrode the checkForBadResponse method with exactly the same content. I deleted this override.
I do have one question though. If I change the JSONFilter and the adapters to use request.getAttribute("format") to access the attribute that the ValidRequestFormat sets all of the code still works. However, how is abdera determining the order in which the filters run? It seems like the only way accessing the attribute would work is if the order went:
ValidRequestFilter -> Adapter -> JSONFilter
Is there some code I am missing that is telling it to use this format? Or am I just crazy?
Thanks.
> move param validity checking to an abdera filter.
> -------------------------------------------------
>
> Key: SHINDIG-303
> URL: https://issues.apache.org/jira/browse/SHINDIG-303
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Attachments: shindig-303_move_param_checking_to_filter.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-303) move param validity checking to an
abdera filter.
Posted by "David Primmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Primmer updated SHINDIG-303:
----------------------------------
Component/s: RESTful API (Java)
> move param validity checking to an abdera filter.
> -------------------------------------------------
>
> Key: SHINDIG-303
> URL: https://issues.apache.org/jira/browse/SHINDIG-303
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Attachments: shindig-303_move_param_checking_to_filter.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-303) move param validity checking to an
abdera filter.
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll resolved SHINDIG-303.
---------------------------------
Resolution: Fixed
Assignee: Cassie Doll
> move param validity checking to an abdera filter.
> -------------------------------------------------
>
> Key: SHINDIG-303
> URL: https://issues.apache.org/jira/browse/SHINDIG-303
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Assignee: Cassie Doll
> Attachments: shindig-303_move_param_checking_to_filter.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-303) move param validity checking to an
abdera filter.
Posted by "David Primmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599264#action_12599264 ]
David Primmer commented on SHINDIG-303:
---------------------------------------
patch depends a little on jira 300 going in.
> move param validity checking to an abdera filter.
> -------------------------------------------------
>
> Key: SHINDIG-303
> URL: https://issues.apache.org/jira/browse/SHINDIG-303
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: David Primmer
> Attachments: shindig-303_move_param_checking_to_filter.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.