You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/09/24 02:45:19 UTC
[PR] Fix TSDataType switch violations in ImportWAL [iotdb]
Caideyipi opened a new pull request, #18711:
URL: https://github.com/apache/iotdb/pull/18711
## Description
The `ImportWAL` snapshot replay added direct `TSDataType` switches after the DataNode architecture rule had been introduced, causing `TSDataTypeSwitchArchitectureTest` to fail.
This change:
- moves aligned and non-aligned `TVList`-to-Tablet value dispatch into `TypeServices.StorageEngine`
- reuses the existing Tablet column allocator for snapshot value arrays
- preserves the existing unsupported snapshot data type error handling
- adds DATE coverage for aligned and non-aligned memtable snapshot replay
## Tests
- `mvn -nsu test -pl iotdb-core/datanode -Dtest=TSDataTypeSwitchArchitectureTest -Dsurefire.failIfNoSpecifiedTests=false`
- `mvn -nsu test -pl iotdb-core/datanode -Dtest=ImportWALTest -Dsurefire.failIfNoSpecifiedTests=false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix TSDataType switch violations in ImportWAL [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18711:
URL: https://github.com/apache/iotdb/pull/18711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org