You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/12 02:33:10 UTC

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #17861: [fix][test] flaky AdminApi2Test.cleanup

poorbarcode commented on code in PR #17861:
URL: https://github.com/apache/pulsar/pull/17861#discussion_r992925720


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java:
##########
@@ -147,6 +152,20 @@ protected ServiceConfiguration getDefaultConf() {
         return conf;
     }
 
+    @Override
+    protected MetadataStoreExtended createConfigurationMetadataStore() throws MetadataStoreException {
+        // use MockZooKeeperSession to provide a unique session id for each instance
+        return new ZKMetadataStore(MockZooKeeperSession.newInstance(mockZooKeeperGlobal), MetadataStoreConfig.builder()

Review Comment:
   Good idea, already changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org