You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "erik daughtrey (JIRA)" <de...@geronimo.apache.org> on 2005/11/17 02:56:28 UTC

[jira] Created: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Installer should only install packs(features) selected at install time
----------------------------------------------------------------------

         Key: GERONIMO-1194
         URL: http://issues.apache.org/jira/browse/GERONIMO-1194
     Project: Geronimo
        Type: Improvement
  Components: installer  
    Versions: 1.0    
 Environment: Maven, installer runtime
    Reporter: erik daughtrey


DJ: The installer currently works by installing everything in a full
geronimo install, and not starting the pieces you don't want.  This is
rather unsatisfactory unless you sell disk space.  The geronimo
assembly is moving to use of the packaging and assembly plugins, and we
can leverage that with the installer.  What I am thinking of is
including a maven repository inside  the installer jar that includes
everything from a full geronimo install with everything, including all
the .car files for the configurations.  Then  we can imitate or use the
assembly plugin to copy the configuration dependencies into the install
target and install the actual configurations.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "erik daughtrey (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=all ]

erik daughtrey updated GERONIMO-1194:
-------------------------------------

    Attachment: installer-ph2-trunk.patch.gz

This patch includes all the features of the last patch posted to GERONIMO-1192 as well as:
---- patch is for trunk.
1. Fixes/work-arounds for IzPack autoinstall xml handling bug
2. config-store update by installer based on pack selections by operator
       -- config-store is created at install time rather than assembly time
3. GUI handling of dependencies for selected runtime options and the ability
           to install a feature, but not activate it at runtime -- effective use of config.xml


> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0-M5
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1
>  Attachments: installer-ph2-trunk.patch.gz
>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=all ]

David Jencks updated GERONIMO-1194:
-----------------------------------

    Fix Version: 1.1
                     (was: 1.0)

We don't have time to get this working reliably for 1.0.  Lets try again for 1.1

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0-M5
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1

>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "erik daughtrey (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=comments#action_12362670 ] 

erik daughtrey commented on GERONIMO-1194:
------------------------------------------

Installer Dev Notes

* Built with IzPack ( http://izforge/izpack ), currently based on 3.8.0

* Added images based on work done by EPiC

* Extends IzPack UserInputPanel type: ValidatePackSelections
    - modules/installer-support component
        IzPack requires that any extensions be in the 
        standalone-compiler jar at the time of the 
        installer.  The maven.xml of this project copies 
        the (izpack)standalone-compiler-3.8.0.jar from 
        the maven repo and injects the output of the 
        compile into a copy of the jar and stores it 
        in the local repo as 
        (geronimo)standalone-compiler-custom-3.8.0.jar. 
        The step which builds the installer 
        (plugins/geronimo-izpack-plugin) has a 
        dependency on this new jar. The assembly step 
        assemblies/j2ee-installer has a dependency on 
        the plugin.

    - added intra-panel port validation
        Up to 7 port port conflicts are reported
        on the "Configuation Checkpoint" panel.
        The limit is imposed by real estate limiateions.

    - added fixes for IzPack auto-install xml processing 
            (need to check 3.8.1 for possible fixes)
        The problem was that the default processing 
        provided by IzPack caused the embedded xml for 
        each panel to be duplicated each time the panel 
        is exited. This was easy to fix for 
        ValidatePackSelections, but required a work-around 
        for the pack selection screen since we don't want 
        to change that portion of IzPack. To fix the 
        pack selection xml the code detects exit from 
        the last panel and gets hold of the ImgPacksPanel 
        xml and a reference to the ImgPacksPanel panel 
        itself via the global InstallData.  The code 
        deletes all the dependent (duplicated) xml 
        and calls the ImgPacksPanel to generate new xml.

    - extended use of JCheckBox (VCheckBox) 
        Added dependency checking for config.xml elements,
        i.e. can't select Jetty web container if 
        J2EE features is selected.  Note that pack (feature) 
        selections already work this way, but this adds 
        the capability to correctly enable/disable config.xml 
        runtime features based on what's installed.

    - Fixed IzPack *feature* of adding/removing 
            checkboxes from panel based on whether the pack 
            is selected. 
        Add/remove caused the checkboxes to walk off the screen
        when the related pack is selected/deselected/selected.  
        The change simply makes unselected pack related fields 
        invisible and vice-versa.

    - Added support for a "configuration complete" panel 
        to display list of port conflicts to repair or "success". 
        The forward button is disabled when conflicts exist. The 
        operator is expected to fix any port conflicts before 
        continuing.


* Added plugin for izpack to build the installer
        - plugins/geronimo-izpack-plugin builds the installer. 
            Assemblies/j2ee-installer uses the 
            plugins/geronimo-assembly-plugin to create the 
            install image which IzPack embeds into the installer 
            jar.

* IzPack variables
	- Throughout the install, IzPack variables are 
            updated which may be used by IzPack to replace 
            values in "parsable" files (geronimio-izpack.xml).
            Config.xml and configure.xml include variables 
            to be replaced by IzPack after the install image 
            is created. Extension code creates variables 
            for each pack, e.g. ${J2EE.Features}, which are 
            set according to whether the pack is selected 
            or not. 
        - izpack-user-input.xml creates variables like the 
            pack variables, but named like 
            ${J2EE.Features.enable}. These variables are 
            set/reset by the VCheckBoxes based on whether 
            each feature is to be enabled at runtime 
            (config.xml).
        - The pack variables are used in the project.xml of
            assemblies/j2ee-installer (see config-store 
            handling below) to map configuration archives
            to packs.

* Config-store handling
    - Built module (modules/installer-processing) in 
        org.apache.geronimo.installer.processing called 
        ConfigInstaller which builds the config store after 
        the install image is laid down by the installer.
        ConfigInstaller.java reads 
        ${INSTALL_PATH}/var/config/configure.xml 
        to determine which configuration archive (CAR) files 
        should be installed into the configuration.
    - Configure.xml is created by 
        plugins/geronimo-assembly-plugin/plugin.jelly from
        pack information added to the project.xml of 
        assemblies/j2ee-installer and placed into the 
        install image for later processing by 
        ConfigInstaller. The file is marked parsable 
        in geronimo-izpack.xml and the variables of 
        configure.xml are updated at install time 
        after the image is created. Each pack selected 
        will be "configured" into config store.

    - ConfigInstaller is invoked as part of the "processing" 
        capability of IzPack. ConfigInstaller is given a 
        classpath to itself( copied to var/temp since it's
        not needed after install), xerces and the parser APIs.

    - ConfigInstaller builds its own classloader based on 
        all jars in the install image to allow it to call "org.apache.geronimo.plugin.assembly.LocalConfigInstaller"
        to do the actual install of each config.

    - Since ConfigInstaller is a module and there 
        is a dependency on a plugin, reflection is used to 
        invoke the LocalConfigInstaller to eliminate build
        dependencies.  It would be nice to move the brunt of 
        LocalConfigInstaller into a module at some point 
        to allow easier access.

    - All this aside, reflection is necessary to allow 
        the classloader to work anyway. Any direct dependency 
        in the code can wreck the ability of the class loader 
        to load off the path built by finding the jars in the 
        install image. For this reason, reflection is also 
        used internally by the ConfigInstaller to load parts 
        of itself (ConfigWorker) allowint ConfigWorker and
        LocalConfigInstaller to find the classes needed to 
        resolve dependencies contained within the configuration 
        archives being installed.
		

* Config.xml handling
    - Throughout the install, variables are set which may 
        be used by IzPack for parsable files. As mentioned above.  
        Variables are set to be parsed into config.xml by IzPack.
        The variables are basically set by the panel selections 
        for "active at runtime" for each configurable item.

--erik

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1
>  Attachments: installer-ph2-trunk.patch.gz
>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "erik daughtrey (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=all ]

erik daughtrey updated GERONIMO-1194:
-------------------------------------

    Geronimo Info: [Patch Available]
          Version: 1.0
                       (was: 1.0-M5)

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1
>  Attachments: installer-ph2-trunk.patch.gz
>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=all ]

Aaron Mulder updated GERONIMO-1194:
-----------------------------------

    Fix Version: 1.0
        Version: 1.0-M5
                     (was: 1.0)
      Assign To: David Jencks

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0-M5
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.0

>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=comments#action_12362752 ] 

David Jencks commented on GERONIMO-1194:
----------------------------------------

The installer partly works for me.  Here are some remaining problems:

1. It is not clear what the copyright statement on the files in the new modules should be.  We need advice from experts.

2. The installer does not know about the openejb, axis, openejb-builder, or axis-builder modules.

3. javamail/smtp doesn't work.  I set it to load=false for now.  If selected, the javamail car does not get installed.

4. there is no default database: the system database should be installed as part of j2ee features.  I set up the config.xml for this but I'm not sure what is making the copy happen.  In any case the choice should be removed IMO.

5. IMO all selected cars should be enabled by default.  This does not happen if you select tomcat and some tomcat apps: they are all disabled by default.

6. We should try to copy in only the jars needed by the configs plus the few that are included into the installer independent of any config.

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1
>  Attachments: installer-ph2-trunk.patch.gz
>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=all ]
     
David Jencks closed GERONIMO-1194:
----------------------------------

    Fix Version: 1.0.1
     Resolution: Fixed

The installer now installs all the jars, but only the configs that you select.  Erik is going to open a new issue for installing only the jars needed by the actually installed configs.

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1, 1.0.1
>  Attachments: installer-ph2-trunk.patch.gz
>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=comments#action_12362761 ] 

David Jencks commented on GERONIMO-1194:
----------------------------------------

Merged with slight modifications to use parameterized release notes version to 1.0 branch:
Sending        1.0/assemblies/j2ee-installer/maven.xml
Sending        1.0/assemblies/j2ee-installer/project.xml
Sending        1.0/assemblies/j2ee-installer/src/izpack/geronimo-izpack.xml
Sending        1.0/assemblies/j2ee-installer/src/izpack/izpack-process.xml
Sending        1.0/assemblies/j2ee-installer/src/izpack/izpack-user-input.xml
Sending        1.0/assemblies/j2ee-installer/src/var/config/config.xml
Adding         1.0/modules/installer-processing
Adding         1.0/modules/installer-processing/LICENSE.txt
Adding         1.0/modules/installer-processing/NOTICE.txt
Adding         1.0/modules/installer-processing/maven.xml
Adding         1.0/modules/installer-processing/project.properties
Adding         1.0/modules/installer-processing/project.xml
Adding         1.0/modules/installer-processing/src
Adding         1.0/modules/installer-processing/src/java
Adding         1.0/modules/installer-processing/src/java/org
Adding         1.0/modules/installer-processing/src/java/org/apache
Adding         1.0/modules/installer-processing/src/java/org/apache/geronimo
Adding         1.0/modules/installer-processing/src/java/org/apache/geronimo/installer
Adding         1.0/modules/installer-processing/src/java/org/apache/geronimo/installer/processing
Adding         1.0/modules/installer-processing/src/java/org/apache/geronimo/installer/processing/ConfigInstaller.java
Adding         1.0/modules/installer-support
Adding         1.0/modules/installer-support/LICENSE.txt
Adding         1.0/modules/installer-support/NOTICE.txt
Adding         1.0/modules/installer-support/maven.xml
Adding         1.0/modules/installer-support/project.properties
Adding         1.0/modules/installer-support/project.xml
Adding         1.0/modules/installer-support/src
Adding         1.0/modules/installer-support/src/java
Adding         1.0/modules/installer-support/src/java/com
Adding         1.0/modules/installer-support/src/java/com/izforge
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/GeronimoConfigProcessor.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/PasswordGroup.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/ProcessPanelAutomationHelper.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/ProcessingClient.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/Processor.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/RuleInputField.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/RuleTextField.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/ValidatePackSelections.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/ValidatePackSelectionsAutomationHelper.java
Adding         1.0/modules/installer-support/src/java/com/izforge/izpack/panels/Validator.java
Sending        1.0/plugins/geronimo-assembly-plugin/plugin.jelly
Sending        1.0/plugins/geronimo-izpack-plugin/plugin.jelly
Sending        1.0/plugins/geronimo-izpack-plugin/project.xml
Transmitting file data .........
Committed revision 369138.    

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1
>  Attachments: installer-ph2-trunk.patch.gz
>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1194) Installer should only install packs(features) selected at install time

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1194?page=comments#action_12362751 ] 

David Jencks commented on GERONIMO-1194:
----------------------------------------

Applied with some modifications to config.xml to head.  See next comment as well.
Sending        assemblies/j2ee-installer/maven.xml
Sending        assemblies/j2ee-installer/project.xml
Sending        assemblies/j2ee-installer/src/izpack/geronimo-izpack.xml
Sending        assemblies/j2ee-installer/src/izpack/izpack-process.xml
Sending        assemblies/j2ee-installer/src/izpack/izpack-user-input.xml
Sending        assemblies/j2ee-installer/src/var/config/config.xml
Adding         modules/installer-processing
Adding         modules/installer-processing/LICENSE.txt
Adding         modules/installer-processing/NOTICE.txt
Adding         modules/installer-processing/maven.xml
Adding         modules/installer-processing/project.properties
Adding         modules/installer-processing/project.xml
Adding         modules/installer-processing/src
Adding         modules/installer-processing/src/java
Adding         modules/installer-processing/src/java/org
Adding         modules/installer-processing/src/java/org/apache
Adding         modules/installer-processing/src/java/org/apache/geronimo
Adding         modules/installer-processing/src/java/org/apache/geronimo/installer
Adding         modules/installer-processing/src/java/org/apache/geronimo/installer/processing
Adding         modules/installer-processing/src/java/org/apache/geronimo/installer/processing/ConfigInstaller.java
Adding         modules/installer-support
Adding         modules/installer-support/LICENSE.txt
Adding         modules/installer-support/NOTICE.txt
Adding         modules/installer-support/maven.xml
Adding         modules/installer-support/project.properties
Adding         modules/installer-support/project.xml
Adding         modules/installer-support/src
Adding         modules/installer-support/src/java
Adding         modules/installer-support/src/java/com
Adding         modules/installer-support/src/java/com/izforge
Adding         modules/installer-support/src/java/com/izforge/izpack
Adding         modules/installer-support/src/java/com/izforge/izpack/panels
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/GeronimoConfigProcessor.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/PasswordGroup.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/ProcessPanelAutomationHelper.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/ProcessingClient.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/Processor.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/RuleInputField.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/RuleTextField.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/ValidatePackSelections.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/ValidatePackSelectionsAutomationHelper.java
Adding         modules/installer-support/src/java/com/izforge/izpack/panels/Validator.java
Sending        plugins/geronimo-assembly-plugin/plugin.jelly
Sending        plugins/geronimo-izpack-plugin/plugin.jelly
Sending        plugins/geronimo-izpack-plugin/project.xml
Transmitting file data ..............................
Committed revision 369099.         

> Installer should only install packs(features) selected at install time
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-1194
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1194
>      Project: Geronimo
>         Type: Improvement
>   Components: installer
>     Versions: 1.0
>  Environment: Maven, installer runtime
>     Reporter: erik daughtrey
>     Assignee: David Jencks
>      Fix For: 1.1
>  Attachments: installer-ph2-trunk.patch.gz
>
> DJ: The installer currently works by installing everything in a full
> geronimo install, and not starting the pieces you don't want.  This is
> rather unsatisfactory unless you sell disk space.  The geronimo
> assembly is moving to use of the packaging and assembly plugins, and we
> can leverage that with the installer.  What I am thinking of is
> including a maven repository inside  the installer jar that includes
> everything from a full geronimo install with everything, including all
> the .car files for the configurations.  Then  we can imitate or use the
> assembly plugin to copy the configuration dependencies into the install
> target and install the actual configurations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira