You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Fernando (JIRA)" <ji...@apache.org> on 2008/12/09 21:15:44 UTC
[jira] Created: (TAP5-407) DocumentLinker not commenting Javascript
block properly
DocumentLinker not commenting Javascript block properly
-------------------------------------------------------
Key: TAP5-407
URL: https://issues.apache.org/jira/browse/TAP5-407
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.17, 5.0.16, 5.0.15, 5.1.0.0, 5.1, 5.0.18
Reporter: Fernando
Attachments: doc-js.diff
The DocumentLinker is not commenting the javascript block properly. It needs to open with "<!-- //" instead of just "<!--". (patch attached)
even a wiki on tapestry shows how to use the javascript comments properly, and says to please pay attention to how they are done...
http://wiki.apache.org/tapestry/Tapestry5HowToIncludeJavaScript
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAP5-407) DocumentLinker not commenting Javascript
block properly
Posted by "Fernando (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fernando updated TAP5-407:
--------------------------
Attachment: doc-js.diff
easy line liner.
> DocumentLinker not commenting Javascript block properly
> -------------------------------------------------------
>
> Key: TAP5-407
> URL: https://issues.apache.org/jira/browse/TAP5-407
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Attachments: doc-js.diff
>
>
> The DocumentLinker is not commenting the javascript block properly. It needs to open with "<!-- //" instead of just "<!--". (patch attached)
> even a wiki on tapestry shows how to use the javascript comments properly, and says to please pay attention to how they are done...
> http://wiki.apache.org/tapestry/Tapestry5HowToIncludeJavaScript
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAP5-407) DocumentLinker not commenting
Javascript block properly
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659707#action_12659707 ]
Howard M. Lewis Ship commented on TAP5-407:
-------------------------------------------
Question: why is it relevant whether the JavaScript is in a comment block or not? That was important 5+ years ago before browsers universally supports the <script> tag.
> DocumentLinker not commenting Javascript block properly
> -------------------------------------------------------
>
> Key: TAP5-407
> URL: https://issues.apache.org/jira/browse/TAP5-407
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.1.0.0, 5.1, 5.0.15, 5.0.16, 5.0.17, 5.0.18
> Reporter: Fernando
> Attachments: doc-js.diff
>
>
> The DocumentLinker is not commenting the javascript block properly. It needs to open with "<!-- //" instead of just "<!--". (patch attached)
> even a wiki on tapestry shows how to use the javascript comments properly, and says to please pay attention to how they are done...
> http://wiki.apache.org/tapestry/Tapestry5HowToIncludeJavaScript
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAP5-407) DocumentLinker should not use the
deprecated practice of HTML commenting out the