You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/05/29 09:54:37 UTC
[GitHub] [arrow] raulcd opened a new pull request, #35811: GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs
raulcd opened a new pull request, #35811:
URL: https://github.com/apache/arrow/pull/35811
### Rationale for this change
We are duplication the Closes issue_id comment on PRs adding it to both the PR body and a comment. There was some discussion to remove it from the comment.
### What changes are included in this PR?
Remove adding extra comment to PR and check whether `Closes XXX` was already added on the body instead of checking comment.
### Are these changes tested?
Yes, I have tested on my fork, see this PR: https://github.com/raulcd/arrow/pull/79
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd merged pull request #35811: GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #35811:
URL: https://github.com/apache/arrow/pull/35811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35811: GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35811:
URL: https://github.com/apache/arrow/pull/35811#discussion_r1209544729
##########
.github/workflows/dev_pr/link.js:
##########
@@ -83,22 +83,16 @@ async function commentGitHubURL(github, context, pullRequestNumber, issueID) {
// Make the call to ensure issue exists before adding comment
const issueInfo = await helpers.getGitHubInfo(github, context, issueID, pullRequestNumber);
const message = "* Closes: #" + issueInfo.number
- if (await haveComment(github, context, pullRequestNumber, message)) {
- return;
- }
if (issueInfo){
+ if (context.payload.pull_request.body.includes(message)){
Review Comment:
```suggestion
if (issueInfo) {
if (context.payload.pull_request.body.includes(message)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35811: GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35811:
URL: https://github.com/apache/arrow/pull/35811#issuecomment-1569337113
Benchmark runs are scheduled for baseline = 1951a1ae69590ad58d97f6be929fa14485f81f42 and contender = 431785f3062199b2b9052902b67492b933744833. 431785f3062199b2b9052902b67492b933744833 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3a2ef9da1495475cb00a4d12e9cc70b0...e68849713c7e47fdb728de4a044a4c43/)
[Failed :arrow_down:0.15% :arrow_up:0.62%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9cbaa2cb8a4146c7bfb4b2086cdd64e7...a299396720f048fdb05bd5727bfdbb1d/)
[Failed :arrow_down:0.0% :arrow_up:11.89%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f26cf415a1df4d91bec40984c1e625e7...69e1c1037e9642f28de8256b359ce1a2/)
[Failed :arrow_down:0.54% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a12fa29ff1a0497ab697dba114d292d9...b3fc87946c754fb3bea699c2d083eb93/)
Buildkite builds:
[Finished] [`431785f3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2946)
[Failed] [`431785f3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2982)
[Failed] [`431785f3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2947)
[Finished] [`431785f3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2972)
[Finished] [`1951a1ae` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2945)
[Finished] [`1951a1ae` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2981)
[Finished] [`1951a1ae` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2946)
[Failed] [`1951a1ae` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2971)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35811: GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35811:
URL: https://github.com/apache/arrow/pull/35811#issuecomment-1566876035
* Closes: #14790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org