You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sc...@apache.org on 2016/12/30 02:02:38 UTC

svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Author: schulte
Date: Fri Dec 30 02:02:38 2016
New Revision: 1776513

URL: http://svn.apache.org/viewvc?rev=1776513&view=rev
Log:
[MNG-5457] Show repository id when downloading or uploading from/to a remote repository

o Updated to correct groovy scripts.


Modified:
    maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
    maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy

Modified: maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy?rev=1776513&r1=1776512&r2=1776513&view=diff
==============================================================================
--- maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy (original)
+++ maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy Fri Dec 30 02:02:38 2016
@@ -21,10 +21,10 @@ import java.io.*;
 
 File buildLog = new File( basedir, 'build.log' )
 assert buildLog.exists()
-String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
-                                        + "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
-String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
-                                       + "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
+String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
+                                        "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
+String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
+                                       "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
 assert buildLog.text =~ expectedDownloadingPattern
 assert buildLog.text =~ expectedDownloadedPattern
 

Modified: maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy?rev=1776513&r1=1776512&r2=1776513&view=diff
==============================================================================
--- maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy (original)
+++ maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy Fri Dec 30 02:02:38 2016
@@ -21,10 +21,10 @@ import java.io.*;
 
 File buildLog = new File( basedir, 'build.log' )
 assert buildLog.exists()
-String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
-                                        + "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
-String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
-                                       + "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
+String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
+                                        "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
+String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
+                                       "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
 assert buildLog.text =~ expectedDownloadingPattern
 assert buildLog.text =~ expectedDownloadedPattern
 



Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Christian Schulte <cs...@schulte.it>.
Am 12/30/16 um 15:47 schrieb Christian Schulte:
> Am 12/30/16 um 11:00 schrieb Guillaume Bou:
>> Is there an issue updating those tests with regard to MNG-5457?
> 
> I do not have a Windows box. Issue was due to the ITs failing on
> Windows. I verified the scripts compile with groovy locally. Currently
> there still seems to be an issue with the Windows path separator.
> 
> Illegal/unsupported escape sequence near index 26
> 
> Running them takes time!
> 
> [INFO] *Total time: 02:37 h*
> [INFO] Finished at: 2016-12-29T21:04:54-08:00
> [INFO] Final Memory: 158M/735M
> 
> <https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-windows/>
> 

All plugin ITs are passing with 3.4.0-SNAPSHOT on Linux, BTW.

<https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-linux/>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Guillaume Boué <gb...@apache.org>.
I'm developing both on Windows and on a Ubuntu VM. The 2 ITs passed with 
the two systems with 3.0.5, 3.3.9 and 3.4.0 before the log format change 
in MNG-5457. I went ahead and committed an update to take account for 
that (the tests no longer rely on reading the logs).

If you want to test unit changes faster, you can run the ITs by building 
specifically the Dependency Plugin. It can be made even faster by using 
the "-Dinvoker.test=..." command-line switch, to select specifically 
which ITs to run. Only when the changes are passing do I run the whole 
thing, otherwise the feedback loop is pretty slow yes.

Guillaume

Le 30/12/2016  15:47, Christian Schulte a crit :
> Am 12/30/16 um 11:00 schrieb Guillaume Bou:
>> Is there an issue updating those tests with regard to MNG-5457?
> I do not have a Windows box. Issue was due to the ITs failing on
> Windows. I verified the scripts compile with groovy locally. Currently
> there still seems to be an issue with the Windows path separator.
>
> Illegal/unsupported escape sequence near index 26
>
> Running them takes time!
>
> [INFO] *Total time: 02:37 h*
> [INFO] Finished at: 2016-12-29T21:04:54-08:00
> [INFO] Final Memory: 158M/735M
>
> <https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-windows/>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


---
L'absence de virus dans ce courrier lectronique a t vrifie par le logiciel antivirus Avast.
https://www.avast.com/antivirus


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Christian Schulte <cs...@schulte.it>.
Am 12/30/16 um 11:00 schrieb Guillaume Bou:
> Is there an issue updating those tests with regard to MNG-5457?

I do not have a Windows box. Issue was due to the ITs failing on
Windows. I verified the scripts compile with groovy locally. Currently
there still seems to be an issue with the Windows path separator.

Illegal/unsupported escape sequence near index 26

Running them takes time!

[INFO] *Total time: 02:37 h*
[INFO] Finished at: 2016-12-29T21:04:54-08:00
[INFO] Final Memory: 158M/735M

<https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-windows/>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Christian Schulte <cs...@schulte.it>.
Am 12/30/16 um 22:06 schrieb Christian Schulte:
> Am 12/30/16 um 19:05 schrieb Stephen Connolly:
>> Given that I'm not seeing any objections yet to throwing out 3.4.x and
>> redoing via cherry-pick as 3.5.x I think we should forget about any tests
>> run with 3.4.0-SNAPSHOTs
>>
>> Focus on the versions we have released.
> 
> The IT is running with 3.4.0-SNAPSHOT and fails due to an issue in the
> launcher script. There still is an issue in the launcher script. I think
> "-f pom with spaces & special char.pom does not get quoted correctly. I
> try to bring up a Windows system with qemu and see if I can fix it.
> 

Looking at that IT, executing Maven in a directory like "spaces &
special char" the launcher will not work correctly. It's not the "-f"
argument. The Windows launcher does not work in directories containing
spaces and special characters.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Christian Schulte <cs...@schulte.it>.
Am 12/30/16 um 19:05 schrieb Stephen Connolly:
> Given that I'm not seeing any objections yet to throwing out 3.4.x and
> redoing via cherry-pick as 3.5.x I think we should forget about any tests
> run with 3.4.0-SNAPSHOTs
> 
> Focus on the versions we have released.

The IT is running with 3.4.0-SNAPSHOT and fails due to an issue in the
launcher script. There still is an issue in the launcher script. I think
"-f pom with spaces & special char.pom does not get quoted correctly. I
try to bring up a Windows system with qemu and see if I can fix it.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Christian Schulte <cs...@schulte.it>.
Am 12/30/16 um 19:05 schrieb Stephen Connolly:
> Focus on the versions we have released.

That IT also fails with Maven 3.3.9 due to the same reason.

[ERROR] The following builds failed:
[ERROR] *  projects\basic-features\space & special char\pom.xml

<https://builds.apache.org/job/maven-plugins-ITs-m3-windows/1797/consoleFull>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Stephen Connolly <st...@gmail.com>.
Given that I'm not seeing any objections yet to throwing out 3.4.x and
redoing via cherry-pick as 3.5.x I think we should forget about any tests
run with 3.4.0-SNAPSHOTs

Focus on the versions we have released.

On Fri 30 Dec 2016 at 17:17, Guillaume Boué <gb...@apache.org> wrote:

>
>
> Le 30/12/2016 à 17:21, Christian Schulte a écrit :
>
> > Am 12/30/16 um 11:00 schrieb Guillaume Boué:
>
> >> Hi Christian,
>
> >>
>
> >> I remember adding those 2 ITs after raising a concern on dev (see
>
> >> attached mail). They were passing with 3.3.9 and latest 3.4.0 at that
> time.
>
> >>
>
> >> Is there an issue updating those tests with regard to MNG-5457? I
>
> >> noticed this is the 5th commit changing it (which I think is a lot), but
>
> >> the build is still failing on Jenkins and locally with 3.3.9. Maybe we
>
> >> can assert that the file was actually downloaded in a different manner,
>
> >> like deleting the folder in the local repository in a setup script, and
>
> >> testing that the POM and JAR files are present in the local repository
>
> >> in the verify script? This is what I did in, e.g., the IT
> "get-artifact".
>
> >>
>
> >> Another simple solution would be to assert that the log file contains
>
> >> either "Downloading:" or "Downloading from ...", instead of using a
>
> >> regular expression (I verified locally that this works fine).
>
> > Do you have a Windows box at hand? Would be cool if you could fix those
>
> > two scripts to work an Windows. I would have to wait another 2.5 hours
>
> > just to find out it's still not working.
>
> >
>
> > I can build all plugins using current 3.4.0-SNAPSHOT by doing:
>
> >
>
> > mvn -DmavenPluginToolsVersion=3.5 -Prun-its verify
>
> >
>
> > There is this issue on Windows and there is another issue with the
>
> > maven-assembly-plugin which seems to be related to the invoker or the
>
> > updates to the Windows launcher scripts. If you could take a look at it
>
> > as well, would also be cool. Failing IT is here:
>
> >
>
> > <
> https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-windows/ws/plugins-trunk/maven-assembly-plugin/target/it/projects/basic-features/space%20&%20special%20char/
> >
>
> >
>
> > build.log contains:
>
> > 'special' is not recognized as an internal or external command,
>
> > operable program or batch file.
>
> > The system cannot find the path specified.
>
> > The system cannot find the path specified.
>
> >
>
> > Maybe an issue with the current mvn.cmd launcher. Someone with Windows
>
> > may fix this in a few minutes.
>
>
>
> I remember looking into them. It's actually an issue with the launcher
>
> script on Windows, that is fixed with 3.4.0. Perhaps we can mark the
>
> build as expected to fail with < 3.4.0, and then have the passing one
>
> with >= 3.4.0.
>
>
>
> >
>
> > If you step over such an issue, I would not mind if you just fix it and
>
> > commit. That's what I am doing as well. Reading some code and noticing
>
> > someone just committed something not working for me, I just fix it and
>
> > commit it. There is no need to write tons of emails. I do read commit
>
> > messages. That's also a channel to use for communication.
>
> >
>
> >
>
> > ---------------------------------------------------------------------
>
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> >
>
>
>
>
>
> ---
>
> L'absence de virus dans ce courrier électronique a été vérifiée par le
> logiciel antivirus Avast.
>
> https://www.avast.com/antivirus
>
>
>
>
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
> --
Sent from my phone

Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Guillaume Boué <gb...@apache.org>.
Le 30/12/2016  17:21, Christian Schulte a crit :
> Am 12/30/16 um 11:00 schrieb Guillaume Bou:
>> Hi Christian,
>>
>> I remember adding those 2 ITs after raising a concern on dev (see
>> attached mail). They were passing with 3.3.9 and latest 3.4.0 at that time.
>>
>> Is there an issue updating those tests with regard to MNG-5457? I
>> noticed this is the 5th commit changing it (which I think is a lot), but
>> the build is still failing on Jenkins and locally with 3.3.9. Maybe we
>> can assert that the file was actually downloaded in a different manner,
>> like deleting the folder in the local repository in a setup script, and
>> testing that the POM and JAR files are present in the local repository
>> in the verify script? This is what I did in, e.g., the IT "get-artifact".
>>
>> Another simple solution would be to assert that the log file contains
>> either "Downloading:" or "Downloading from ...", instead of using a
>> regular expression (I verified locally that this works fine).
> Do you have a Windows box at hand? Would be cool if you could fix those
> two scripts to work an Windows. I would have to wait another 2.5 hours
> just to find out it's still not working.
>
> I can build all plugins using current 3.4.0-SNAPSHOT by doing:
>
> mvn -DmavenPluginToolsVersion=3.5 -Prun-its verify
>
> There is this issue on Windows and there is another issue with the
> maven-assembly-plugin which seems to be related to the invoker or the
> updates to the Windows launcher scripts. If you could take a look at it
> as well, would also be cool. Failing IT is here:
>
> <https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-windows/ws/plugins-trunk/maven-assembly-plugin/target/it/projects/basic-features/space%20&%20special%20char/>
>
> build.log contains:
> 'special' is not recognized as an internal or external command,
> operable program or batch file.
> The system cannot find the path specified.
> The system cannot find the path specified.
>
> Maybe an issue with the current mvn.cmd launcher. Someone with Windows
> may fix this in a few minutes.

I remember looking into them. It's actually an issue with the launcher 
script on Windows, that is fixed with 3.4.0. Perhaps we can mark the 
build as expected to fail with < 3.4.0, and then have the passing one 
with >= 3.4.0.

>
> If you step over such an issue, I would not mind if you just fix it and
> commit. That's what I am doing as well. Reading some code and noticing
> someone just committed something not working for me, I just fix it and
> commit it. There is no need to write tons of emails. I do read commit
> messages. That's also a channel to use for communication.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>


---
L'absence de virus dans ce courrier lectronique a t vrifie par le logiciel antivirus Avast.
https://www.avast.com/antivirus


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Christian Schulte <cs...@schulte.it>.
Am 12/30/16 um 11:00 schrieb Guillaume Bou:
> Hi Christian,
> 
> I remember adding those 2 ITs after raising a concern on dev (see 
> attached mail). They were passing with 3.3.9 and latest 3.4.0 at that time.
> 
> Is there an issue updating those tests with regard to MNG-5457? I 
> noticed this is the 5th commit changing it (which I think is a lot), but 
> the build is still failing on Jenkins and locally with 3.3.9. Maybe we 
> can assert that the file was actually downloaded in a different manner, 
> like deleting the folder in the local repository in a setup script, and 
> testing that the POM and JAR files are present in the local repository 
> in the verify script? This is what I did in, e.g., the IT "get-artifact".
> 
> Another simple solution would be to assert that the log file contains 
> either "Downloading:" or "Downloading from ...", instead of using a 
> regular expression (I verified locally that this works fine).

Do you have a Windows box at hand? Would be cool if you could fix those
two scripts to work an Windows. I would have to wait another 2.5 hours
just to find out it's still not working.

I can build all plugins using current 3.4.0-SNAPSHOT by doing:

mvn -DmavenPluginToolsVersion=3.5 -Prun-its verify

There is this issue on Windows and there is another issue with the
maven-assembly-plugin which seems to be related to the invoker or the
updates to the Windows launcher scripts. If you could take a look at it
as well, would also be cool. Failing IT is here:

<https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-windows/ws/plugins-trunk/maven-assembly-plugin/target/it/projects/basic-features/space%20&%20special%20char/>

build.log contains:
'special' is not recognized as an internal or external command,
operable program or batch file.
The system cannot find the path specified.
The system cannot find the path specified.

Maybe an issue with the current mvn.cmd launcher. Someone with Windows
may fix this in a few minutes.

If you step over such an issue, I would not mind if you just fix it and
commit. That's what I am doing as well. Reading some code and noticing
someone just committed something not working for me, I just fix it and
commit it. There is no need to write tons of emails. I do read commit
messages. That's also a channel to use for communication.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r1776513 - in /maven/plugins/trunk/maven-dependency-plugin/src/it/projects: copy-from-remote-repository/verify.groovy unpack-from-remote-repository/verify.groovy

Posted by Guillaume Boué <gb...@apache.org>.
Hi Christian,

I remember adding those 2 ITs after raising a concern on dev (see 
attached mail). They were passing with 3.3.9 and latest 3.4.0 at that time.

Is there an issue updating those tests with regard to MNG-5457? I 
noticed this is the 5th commit changing it (which I think is a lot), but 
the build is still failing on Jenkins and locally with 3.3.9. Maybe we 
can assert that the file was actually downloaded in a different manner, 
like deleting the folder in the local repository in a setup script, and 
testing that the POM and JAR files are present in the local repository 
in the verify script? This is what I did in, e.g., the IT "get-artifact".

Another simple solution would be to assert that the log file contains 
either "Downloading:" or "Downloading from ...", instead of using a 
regular expression (I verified locally that this works fine).

Guillaume


Le 30/12/2016 � 03:02, schulte@apache.org a �crit :
> Author: schulte
> Date: Fri Dec 30 02:02:38 2016
> New Revision: 1776513
>
> URL: http://svn.apache.org/viewvc?rev=1776513&view=rev
> Log:
> [MNG-5457] Show repository id when downloading or uploading from/to a remote repository
>
> o Updated to correct groovy scripts.
>
>
> Modified:
>      maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
>      maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
>
> Modified: maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy?rev=1776513&r1=1776512&r2=1776513&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy (original)
> +++ maven/plugins/trunk/maven-dependency-plugin/src/it/projects/copy-from-remote-repository/verify.groovy Fri Dec 30 02:02:38 2016
> @@ -21,10 +21,10 @@ import java.io.*;
>   
>   File buildLog = new File( basedir, 'build.log' )
>   assert buildLog.exists()
> -String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
> -                                        + "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
> -String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
> -                                       + "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
> +String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
> +                                        "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
> +String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
> +                                       "/repo/org/apache/maven/its/dependency/fake-remote-copy/1\\.0/fake-remote-copy-1\\.0\\.jar"
>   assert buildLog.text =~ expectedDownloadingPattern
>   assert buildLog.text =~ expectedDownloadedPattern
>   
>
> Modified: maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy?rev=1776513&r1=1776512&r2=1776513&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy (original)
> +++ maven/plugins/trunk/maven-dependency-plugin/src/it/projects/unpack-from-remote-repository/verify.groovy Fri Dec 30 02:02:38 2016
> @@ -21,10 +21,10 @@ import java.io.*;
>   
>   File buildLog = new File( basedir, 'build.log' )
>   assert buildLog.exists()
> -String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
> -                                        + "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
> -String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\", "/")
> -                                       + "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
> +String expectedDownloadingPattern = "Downloading.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
> +                                        "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
> +String expectedDownloadedPattern = "Downloaded.*: file:///" + basedir.getPath().replaceAll( "\\\\", "\\\\") +
> +                                       "/repo/org/apache/maven/its/dependency/fake-remote-unpack/1\\.0/fake-remote-unpack-1\\.0\\.jar"
>   assert buildLog.text =~ expectedDownloadingPattern
>   assert buildLog.text =~ expectedDownloadedPattern
>   
>
>



---
L'absence de virus dans ce courrier �lectronique a �t� v�rifi�e par le logiciel antivirus Avast.
https://www.avast.com/antivirus