[GitHub] [accumulo] ctubbsii commented on a change in pull request #2349: Improve logging message and comments if tablet overlap occurs.

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2349:
URL: https://github.com/apache/accumulo/pull/2349#discussion_r754764088



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
##########
@@ -1433,8 +1432,10 @@ public void loadTablet(TInfo tinfo, TCredentials credentials, String lock,
             all.remove(extent);
 
             if (!all.isEmpty()) {
-              log.error("Tablet {} overlaps previously assigned {} {} {}", extent,
-                  unopenedOverlapping, openingOverlapping, onlineOverlapping + " " + all);
+              log.error(
+                  "Tablet {} overlaps a previously assigned tablet. It is possibly due to a recent split. "
+                      + "Possible overlapping tablets:  Unopened: {}, Opening: {}, Online: {}",
+                  extent, unopenedOverlapping, openingOverlapping, onlineOverlapping);

Review comment:
       I think these are definitely overlapping, not just possibly overlapping
   ```suggestion
                         + "Overlapping tablets: Unopened: {}, Opening: {}, Online: {}",
                     extent, unopenedOverlapping, openingOverlapping, onlineOverlapping);
   ```

##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/ThriftClientHandler.java
##########
@@ -1433,8 +1432,10 @@ public void loadTablet(TInfo tinfo, TCredentials credentials, String lock,
             all.remove(extent);
 
             if (!all.isEmpty()) {
-              log.error("Tablet {} overlaps previously assigned {} {} {}", extent,
-                  unopenedOverlapping, openingOverlapping, onlineOverlapping + " " + all);
+              log.error(
+                  "Tablet {} overlaps a previously assigned tablet. It is possibly due to a recent split. "

Review comment:
       ```suggestion
                     "Tablet {} overlaps a previously assigned tablet, possibly due to a recent split. "
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org