You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/05 21:00:38 UTC
[GitHub] [spark] tanelk commented on a change in pull request #31740: [SPARK_34623][SQL] Remove duplicate window expressions from the Window node
tanelk commented on a change in pull request #31740:
URL: https://github.com/apache/spark/pull/31740#discussion_r588702736
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -946,6 +947,45 @@ object TransposeWindow extends Rule[LogicalPlan] {
}
}
+/**
+ * Replaces duplicate window expressions with an alias in a Project above the Window node.
Review comment:
Isn't the subexpression elimination wholestage codegen specific?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org