[GitHub] feng-tao commented on issue #3740: [AIRFLOW-2888] Remove shell=True and bash from task launch

[GitBox <gi...@apache.org>]

feng-tao commented on issue #3740: [AIRFLOW-2888] Remove shell=True and bash from task launch
URL: https://github.com/apache/incubator-airflow/pull/3740#issuecomment-412974281
 
 
   @dimberman , @bolkedebruin,  this is related to https://github.com/apache/incubator-airflow/pull/3651 and https://github.com/apache/incubator-airflow/pull/3729 which uses random value for secret key.  The original pr owner has a proposed fix(https://github.com/apache/incubator-airflow/pull/3738) which only works if the webserver is deployed on a single machine(not for a cluster of machine for webservers). 
   
   There are two solutions:
   1.  if we don't have a use case for a cluster of webserver, we could go ahead to merge his pr.
   2. if we do, I think we should revert the original two prs and but update the descriptions to indicate users need to update the secret key(e.g read from certain key management services).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services