You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "jmalkin (via GitHub)" <gi...@apache.org> on 2023/06/13 23:16:43 UTC

[GitHub] [datasketches-java] jmalkin commented on a diff in pull request #453: Update theta compact() behavior.

jmalkin commented on code in PR #453:
URL: https://github.com/apache/datasketches-java/pull/453#discussion_r1228795279


##########
src/test/java/org/apache/datasketches/theta/CompactSketchTest.java:
##########
@@ -220,81 +221,226 @@ public void checkMemTooSmallOrdered() {
 
   @Test
   public void checkCompactCachePart() {
-    //phony values except for curCount = 0.
+    //phoney values except for curCount = 0.

Review Comment:
   We can switch to UK spellings but why only this one place in an internal comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org