You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/01/12 17:48:43 UTC
Review Request 42198: GEODE-775: Generate md5 / sha-256 hashes for the
distributions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42198/
-----------------------------------------------------------
Review request for geode, Dick Cavender, Nitin Lamba, and Dan Smith.
Repository: geode
Description
-------
The binary and source distributions created by the build need
accompanying hash files to verification. This change uses the
doList hook to generate the hashes after the distribution is
created.
GEODE-775: Add build support to easily sign a distribution
Setting `-Psign=true -Pkey=XXX` will create a detached signature
file for each distribution. The gpg command must be installed
and the selected key present on the keyring.
Diffs
-----
gemfire-assembly/build.gradle ad466de1eb653e61ad93e1b78c164124addb2009
gradle.properties 3687ff0645456eb35ead8402239e111821b50a8c
Diff: https://reviews.apache.org/r/42198/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 42198: GEODE-775: Generate md5 / sha-256 hashes
for the distributions
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42198/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 9:17 p.m.)
Review request for geode, Dick Cavender, Nitin Lamba, and Dan Smith.
Changes
-------
Thanks for the feedback. Looks like we need to sign each jar artifact anyway. This update uses the signing plugin.
GEODE-775: Add build support to easily sign release files
Use the gradle signing plugin to sign jar artifacts and distributions.
This is only done for release versions (-SNAPSHOT). Exclude KEYS and
signatures from the distributions. Requires a user gradle file with
the following properties:
signing.keyId=
signing.password=
signing.secretKeyRingFile=
Repository: geode
Description
-------
The binary and source distributions created by the build need
accompanying hash files to verification. This change uses the
doList hook to generate the hashes after the distribution is
created.
GEODE-775: Add build support to easily sign a distribution
Setting `-Psign=true -Pkey=XXX` will create a detached signature
file for each distribution. The gpg command must be installed
and the selected key present on the keyring.
Diffs (updated)
-----
build.gradle 1f1077c3672c49b6d500a7861b003ff4e0d69552
gemfire-assembly/build.gradle ad466de1eb653e61ad93e1b78c164124addb2009
Diff: https://reviews.apache.org/r/42198/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 42198: GEODE-775: Generate md5 / sha-256 hashes
for the distributions
Posted by Mark Bretl <mb...@pivotal.io>.
> On Jan. 12, 2016, 5:32 p.m., Dan Smith wrote:
> > Looks pretty good. Rather than invoking gpg from the command line, I think it would be better to use the built in gradle signing plugin:
> >
> > https://docs.gradle.org/current/userguide/signing_plugin.html
+1 For using Gradle Signing plugin
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42198/#review114011
-----------------------------------------------------------
On Jan. 12, 2016, 4:48 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42198/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 4:48 p.m.)
>
>
> Review request for geode, Dick Cavender, Nitin Lamba, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The binary and source distributions created by the build need
> accompanying hash files to verification. This change uses the
> doList hook to generate the hashes after the distribution is
> created.
>
> GEODE-775: Add build support to easily sign a distribution
>
> Setting `-Psign=true -Pkey=XXX` will create a detached signature
> file for each distribution. The gpg command must be installed
> and the selected key present on the keyring.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle ad466de1eb653e61ad93e1b78c164124addb2009
> gradle.properties 3687ff0645456eb35ead8402239e111821b50a8c
>
> Diff: https://reviews.apache.org/r/42198/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 42198: GEODE-775: Generate md5 / sha-256 hashes
for the distributions
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42198/#review114011
-----------------------------------------------------------
Looks pretty good. Rather than invoking gpg from the command line, I think it would be better to use the built in gradle signing plugin:
https://docs.gradle.org/current/userguide/signing_plugin.html
- Dan Smith
On Jan. 12, 2016, 4:48 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42198/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 4:48 p.m.)
>
>
> Review request for geode, Dick Cavender, Nitin Lamba, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The binary and source distributions created by the build need
> accompanying hash files to verification. This change uses the
> doList hook to generate the hashes after the distribution is
> created.
>
> GEODE-775: Add build support to easily sign a distribution
>
> Setting `-Psign=true -Pkey=XXX` will create a detached signature
> file for each distribution. The gpg command must be installed
> and the selected key present on the keyring.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle ad466de1eb653e61ad93e1b78c164124addb2009
> gradle.properties 3687ff0645456eb35ead8402239e111821b50a8c
>
> Diff: https://reviews.apache.org/r/42198/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>