You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/18 14:07:21 UTC
[GitHub] [lucene] rmuir opened a new pull request, #901: remove commented-out/obselete AwaitsFix
rmuir opened a new pull request, #901:
URL: https://github.com/apache/lucene/pull/901
All of these issues are fixed, but the AwaitsFix annotation is still there, just commented out.
This causes confusion and makes it harder to keep an eye/review the AwaitsFix tests, e.g. false positives when running `git grep AwaitsFix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #901: remove commented-out/obselete AwaitsFix
Posted by GitBox <gi...@apache.org>.
rmuir merged PR #901:
URL: https://github.com/apache/lucene/pull/901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #901: remove commented-out/obselete AwaitsFix
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #901:
URL: https://github.com/apache/lucene/pull/901#issuecomment-1130485931
I'll take a look at TestMatchRegionRetriever tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #901: remove commented-out/obselete AwaitsFix
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #901:
URL: https://github.com/apache/lucene/pull/901#issuecomment-1131960030
> Well, we dug it up, eventually. What other means are there for marking tests that fail for some reason (that we don't know how to fix)? If you remove the test, it'll be gone forever.
I don't have a better solution. I like that at least the annotation forces an issue to be opened.
> The replication tests (forks) I think I can handle - just not today.
Thanks! I wonder if forking is truly needed? I think it just wants to simulate "crashing" or bringing down nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #901: remove commented-out/obselete AwaitsFix
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #901:
URL: https://github.com/apache/lucene/pull/901#issuecomment-1131910048
> This test has been @AwaitsFix for over 6 years now, this is my concern with this annotation :(
Well, we dug it up, eventually. What other means are there for marking tests that fail for some reason (that we don't know how to fix)? If you remove the test, it'll be gone forever.
The replication tests (forks) I think I can handle - just not today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #901: remove commented-out/obselete AwaitsFix
Posted by GitBox <gi...@apache.org>.
dweiss commented on PR #901:
URL: https://github.com/apache/lucene/pull/901#issuecomment-1132716807
I filed a PR fixing those "forking" tests (not just the ones above, others as well). Rewriting the nrt tests completely so that they don't fork at all is a more complex task and probably deserves an issue on its own rights.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #901: remove commented-out/obselete AwaitsFix
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #901:
URL: https://github.com/apache/lucene/pull/901#issuecomment-1130101538
FYI there are only 6 `@AwaitsFix` tests left:
* `TestICUTokenizerCJK`: we are really actually waiting on a third-party fix, i checked ICU bugtracker and adrien's bug is still open. we just have to check it from time to time.
* `TestControlledRealTimeReopenThread`: the test needs to be reworked to no longer rely on wall-clock time.
* `TestMatchRegionRetriever`: there is at least a draft PR open for the fix, but unclear of the status from the JIRA.
* `TestMoreLikeThis`: from reading the JIRA, it may or may not be fixed. seems like the test needs to be beasted.
* `TestStressNRTReplication`: this one forks its own JVM, in an outdated way incompatible with java module system. the test may require some rework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #901: remove commented-out/obselete AwaitsFix
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #901:
URL: https://github.com/apache/lucene/pull/901#issuecomment-1131804325
Thanks @dweiss for taking one off the list!
I looked into the MoreLikeThis one, https://issues.apache.org/jira/browse/LUCENE-7161
This test has been `@AwaitsFix` for over 6 years now, this is my concern with this annotation :(
I beasted the test (probably "incorrectly/illegally") and made it pop relatively easily, but then resulting seeds don't reproduce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org