You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/15 04:59:19 UTC
[GitHub] [shardingsphere] Swastyy opened a new pull request #13605: Show triggers in dalstatement.g4
Swastyy opened a new pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605
Fixes #13599
Changes proposed in this pull request:
-
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#issuecomment-971624982
Hi @Swastyy, any progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
strongduanmu closed pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#discussion_r749006460
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
##########
@@ -234,8 +234,8 @@ showStatus
: SHOW (GLOBAL | SESSION)? STATUS showFilter?
;
-showTrriggers
- : SHOW TRIGGER fromSchema? showFilter?
+showTriggers
+ : SHOW TRIGGERS fromSchema? showFilter?
Review comment:
@Swastyy Can you add some parse test for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#discussion_r749019709
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
##########
@@ -234,8 +234,8 @@ showStatus
: SHOW (GLOBAL | SESSION)? STATUS showFilter?
;
-showTrriggers
- : SHOW TRIGGER fromSchema? showFilter?
+showTriggers
+ : SHOW TRIGGERS fromSchema? showFilter?
Review comment:
> Is there any example PR which can be a reference for it?
@Swastyy You can refer pr #13446.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#issuecomment-976082722
@Swastyy This issue has been fixed by #13629, so I will close this PR. You are very welcome to continue participating in other tasks in the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#issuecomment-971642489
> Hi @Swastyy, any progress?
Hi @strongduanmu I have an exam so I was busy, I will try completing it in 2 to 3 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on a change in pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
Swastyy commented on a change in pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#discussion_r749007774
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/antlr4/imports/mysql/DALStatement.g4
##########
@@ -234,8 +234,8 @@ showStatus
: SHOW (GLOBAL | SESSION)? STATUS showFilter?
;
-showTrriggers
- : SHOW TRIGGER fromSchema? showFilter?
+showTriggers
+ : SHOW TRIGGERS fromSchema? showFilter?
Review comment:
Is there any example PR which can be a reference for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#issuecomment-968573974
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13605](https://codecov.io/gh/apache/shardingsphere/pull/13605?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76445cc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/37accefecfbb95b460b934bc21d134867ac3570d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37accef) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/13605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #13605 +/- ##
=========================================
Coverage 63.55% 63.55%
Complexity 1669 1669
=========================================
Files 2727 2727
Lines 40701 40701
Branches 6954 6954
=========================================
Hits 25866 25866
Misses 12869 12869
Partials 1966 1966
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13605?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13605?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37accef...76445cc](https://codecov.io/gh/apache/shardingsphere/pull/13605?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #13605: Show triggers in dalstatement.g4
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #13605:
URL: https://github.com/apache/shardingsphere/pull/13605#issuecomment-972795843
> as busy, I will try completing it
@Swastyy Okay, waiting for your good news.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org