[jira] [Commented] (DRILL-2649) Math and Trig page seems to refer to types that are not Drill SQL types

["Kristine Hahn (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502937#comment-14502937 ] 

Kristine Hahn commented on DRILL-2649:
--------------------------------------

Thanks, fixed and ready for review: http://tshiran.github.io/drill/docs/math-and-trig/
{quote}
The page lists SMALLINT but not TINYINT. Is that inconsistency intended?
{quote}
Yes, this is intended. I understand from [~seanhychu] smallint might be supported soon but afaik, not tinyint.

> Math and Trig page seems to refer to types that are not Drill SQL types
> -----------------------------------------------------------------------
>
>                 Key: DRILL-2649
>                 URL: https://issues.apache.org/jira/browse/DRILL-2649
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Kristine Hahn
>
> The Math and Trig page at http://drill.apache.org/docs/math-and-trig/ refers to data types UINT1, UINT2, UINT4, UINT8, FLOAT4, FLOAT8, DECIMAL9, and DECIMAL18.
> However, these do not seem to be Drill SQL types, at least based on their behavior in CAST expressions.  For example:
> 0: jdbc:drill:zk=local> SELECT CAST( 1 as UINT4 ) FROM INFORMATION_SCHEMA.CATALOGS;
> Mar 31, 2015 9:47:51 PM org.eigenbase.sql.validate.SqlValidatorException <init>
> SEVERE: org.eigenbase.sql.validate.SqlValidatorException: Unknown datatype name 'UINT4'
> Mar 31, 2015 9:47:51 PM org.eigenbase.util.EigenbaseException <init>
> SEVERE: org.eigenbase.util.EigenbaseContextException: From line 1, column 19 to line 1, column 23: Unknown datatype name 'UINT4'
> Query failed: SqlValidatorException: Unknown datatype name 'UINT4'
> Error: exception while executing query: Failure while executing query. (state=,code=0)
> 0: jdbc:drill:zk=local> 
> Those names seem to refer to Drill _internal_ types (or types used in the storage plugin interface), not Drill _SQL_ types.  
> Since the Math and Trig page deals with the SQL interface, it should be in terms of Drill SQL types, not Drill internal/non-SQL types.
> Additionally:
> - The page says "INT" (a syntax-only shortcut) rather than "INTEGER" (the actual name of the type).
> - The page lists SMALLINT but not TINYINT.  Is that inconsistency intended?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)