[GitHub] [incubator-hugegraph] javeme commented on a diff in pull request #2091: refact: update with release branch

[GitBox <gi...@apache.org>]

javeme commented on code in PR #2091:
URL: https://github.com/apache/incubator-hugegraph/pull/2091#discussion_r1070360249


##########
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeVertex.java:
##########
@@ -462,10 +464,14 @@ public <V> VertexProperty<V> property(
             E.checkArgument(!this.hasProperty(propertyKey.id()),
                             "Can't update primary key: '%s'", key);
         }
+        if (value == null) {
+            this.removeProperty(propertyKey.id());
+            return EmptyVertexProperty.instance();
+        }

Review Comment:
   prefer to move this block into PR https://github.com/apache/incubator-hugegraph/pull/206 for consistent logic.



##########
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeEdge.java:
##########
@@ -369,7 +369,7 @@ public void vertices(HugeVertex owner, HugeVertex other) {
         if (ownerLabel.equals(this.label.sourceLabel())) {
             this.vertices(true, owner, other);
         } else {
-            // TODO: why when compare the label but ignore the result?
+            // TODO: why compare the label but ignore the result?

Review Comment:
   seems missing assert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org