You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org> on 2007/01/23 18:27:49 UTC

[jira] Updated: (QPID-315) JMSMessageProperties not all set when converting messages

     [ https://issues.apache.org/jira/browse/QPID-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-315:
----------------------------------

    Description: 
Currently BasicMessageProducer.sendImpl currently contains the call:

AbstractJMSMessage message = convertToNativeMessage(origMessage);

The convertToNativeMessage(Message message) method creates a new Qpid Message instance and copies in some of the JMS property values of the incoming message.

e.g. the JMS delivery mode is copied into the new object with:

	newMessage.setJMSDeliveryMode(message.getJMSDeliveryMode());

These JMS properties are set:

JMSDeliveryMode
JMSPriority
JMSReplyTo
JMSType

However, the following JMS properties are not being set for incoming messages:

JMSDestination
JMSExpiration
JMSMessageID
JMSTimestamp
JMSCorrelationID
JMSType
JMSRedelivered

This needs to be corrected to add one more property (after discussion with Rob Godfrey):

JMSCorrelationID

The others are all set elsewhere on the send method so don't need to be set here (or would be actively  problematic if set here).




  was:
Currently BasicMessageProducer.sendImpl currently contains the call:

AbstractJMSMessage message = convertToNativeMessage(origMessage);

The convertToNativeMessage(Message message) method creates a new Qpid Message instance and copies in some of the JMS property values of the incoming message.

e.g. the JMS delivery mode is copied into the new object with:

	newMessage.setJMSDeliveryMode(message.getJMSDeliveryMode());

These JMS properties are set:

JMSDeliveryMode
JMSPriority
JMSReplyTo

However, the following JMS properties are not being set for incoming messages:

JMSDestination
JMSExpiration
JMSMessageID
JMSTimestamp
JMSCorrelationID
JMSType
JMSRedelivered

This needs to be corrected.





Updated details to be more useful/accurate

> JMSMessageProperties not all set when converting messages
> ---------------------------------------------------------
>
>                 Key: QPID-315
>                 URL: https://issues.apache.org/jira/browse/QPID-315
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: M1
>            Reporter: Marnie McCormack
>         Assigned To: Marnie McCormack
>             Fix For: M2
>
>
> Currently BasicMessageProducer.sendImpl currently contains the call:
> AbstractJMSMessage message = convertToNativeMessage(origMessage);
> The convertToNativeMessage(Message message) method creates a new Qpid Message instance and copies in some of the JMS property values of the incoming message.
> e.g. the JMS delivery mode is copied into the new object with:
> 	newMessage.setJMSDeliveryMode(message.getJMSDeliveryMode());
> These JMS properties are set:
> JMSDeliveryMode
> JMSPriority
> JMSReplyTo
> JMSType
> However, the following JMS properties are not being set for incoming messages:
> JMSDestination
> JMSExpiration
> JMSMessageID
> JMSTimestamp
> JMSCorrelationID
> JMSType
> JMSRedelivered
> This needs to be corrected to add one more property (after discussion with Rob Godfrey):
> JMSCorrelationID
> The others are all set elsewhere on the send method so don't need to be set here (or would be actively  problematic if set here).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.