You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@hertzbeat.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2024/09/10 05:56:47 UTC
[PR] [bugfix] disallow adding tag with same key same value [hertzbeat]
Aias00 opened a new pull request, #2700:
URL: https://github.com/apache/hertzbeat/pull/2700
## What's changed?
<!-- Describe Your PR Here -->
disallow adding tag with same key same value
link: https://github.com/apache/hertzbeat/issues/2690
## Checklist
- [x] I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
- [x] I have written the necessary doc or comment.
- [x] I have added the necessary unit tests and all cases have passed.
## Add or update API
- [x] I have added the necessary [e2e tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [PR] [bugfix] disallow adding tag with same key same value [hertzbeat]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 commented on code in PR #2700:
URL: https://github.com/apache/hertzbeat/pull/2700#discussion_r1752259504
##########
manager/src/main/java/org/apache/hertzbeat/manager/service/impl/TagServiceImpl.java:
##########
@@ -60,6 +60,10 @@ public class TagServiceImpl implements TagService {
public void addTags(List<Tag> tags) {
Review Comment:
👍 hi, how about the existed same name and value when modifyTag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [PR] [bugfix] disallow adding tag with same key same value [hertzbeat]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on code in PR #2700:
URL: https://github.com/apache/hertzbeat/pull/2700#discussion_r1753207923
##########
manager/src/main/java/org/apache/hertzbeat/manager/service/impl/TagServiceImpl.java:
##########
@@ -60,6 +60,10 @@ public class TagServiceImpl implements TagService {
public void addTags(List<Tag> tags) {
Review Comment:
okay, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [PR] [bugfix] disallow adding tag with same key same value [hertzbeat]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 merged PR #2700:
URL: https://github.com/apache/hertzbeat/pull/2700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org