You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/28 15:40:38 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #8004: Fix HPACK eviction iterator manipulation
shinrich opened a new pull request #8004:
URL: https://github.com/apache/trafficserver/pull/8004
Found this while investigating #7838. According to https://en.cppreference.com/w/cpp/container/deque/pop_back#:~:text=std%3A%3Adeque%3A%3Apop_back&text=Removes%20the%20last%20element%20of,the%2Dend%20iterator%20is%20invalidated. After pop_back is called "Iterators and references to the erased element are invalidated". In the current logic, the increment is called on the old iterator after pop_back is called.
I'm not 100% sure this is causing our crash. If most of the time only one item is evicted, this case won't happen very often and maybe most of the time you get lucky.
I will get this patched rolled into our build. Even if it does not fix the crash the new logic is safer and looks cleaner.
This closes #7838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8004: Fix HPACK eviction iterator manipulation
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8004:
URL: https://github.com/apache/trafficserver/pull/8004#issuecomment-869826245
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #8004: Fix HPACK eviction iterator manipulation
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #8004:
URL: https://github.com/apache/trafficserver/pull/8004#issuecomment-869826245
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8004: Fix HPACK eviction iterator manipulation
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8004:
URL: https://github.com/apache/trafficserver/pull/8004#issuecomment-883739630
Cherry-picked to v9.1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #8004: Fix HPACK eviction iterator manipulation
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #8004:
URL: https://github.com/apache/trafficserver/pull/8004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8004: Fix HPACK eviction iterator manipulation
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8004:
URL: https://github.com/apache/trafficserver/pull/8004#issuecomment-870104240
@masaori335 will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8004: Fix HPACK eviction iterator manipulation
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8004:
URL: https://github.com/apache/trafficserver/pull/8004#issuecomment-870104240
@masaori335 will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org