You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "dave2wave (via GitHub)" <gi...@apache.org> on 2025/10/30 19:48:16 UTC
[I] New compose project options for license check excludes (tooling-trusted-releases)
dave2wave opened a new issue, #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274
Add two new text arrays as compose project options:
1. Source excludes patterns.
2. Binary excludes patterns.
These align with _Source artifact paths_ and _Binary artifact paths_.
The release manager can paste these into project options from whatever their source is. If these are empty then fallback to looking for an included _rat excludes file_.
Editing these while composing a release would invalidate prior checks and cause a new evaluation.
When running the checks a temporary excludes file can be created.
Let's discuss if a direct button on the compose button would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3730436637
Resolved by 3059c05f75791f1ff01694e524d4470bc078747a, 7f0911a567a4c7220225e1e0ed02c904d97e37d3, 1bbddbf438a46c0d8cc387827c033a5deb523174, 99013e96d18dab83a5fc7cdcbf3432c505771678, and 702b4b3c93e584a92617ffb8980db315d1906f25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3481896259
It seems reasonable to use `.gitignore` to partially-configure RAT, though the Tomcat project would prefer not to do that; we don't want to accidentally have junk in the release binaries such as `.*.sw~` temp files and such.
Tomcat already has a RAT configuration file available in res/rat/rat-excludes.txt which simply contains a series of filename patterns. This file location is likely not terribly common, but we could move it, or place a reference to it in maybe an ATR-specific configuration file somewhere, or configure it as a part of the project, etc. in ATR itself. Project-level config might be more convenient than trying to drop that file into every release artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3708472552
In Release Policy make it so that exclude patterns are visible and controllable. These excludes are to be used for both our License Check and RAT Checks when a .rat-excludes is missing. In fact if you find .rat-excludes then you can overwrite the source excludes with the content of .rat-excludes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3481115390
We currently use [`gitignore_parser`](https://github.com/mherrmann/gitignore_parser) to match _Source artifact paths_ and _Binary artifact paths_. Should the _Source excludes patterns_ and _Binary excludes patterns_ configuration options also use `gitignore_parser`?
If we're looking for compatibility with RAT instead, note that RAT uses an extremely complicated pattern syntax which would be a huge amount of work to replicate in Python. We could potentially replicate a small subset of it. We use [`.gitignore` syntax](https://git-scm.com/docs/gitignore) for the existing options because it is very widely used and easily understood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3708322068
We've updated how RAT works in 40013cbb7dcb72c5557289ef54974f9159da02dc. https://github.com/apache/tooling-trusted-releases/issues/467#issuecomment-3708234146 explains the new approach and rules. This issue was only continuing to be open because it tracks #296, but the behaviour will have now changed entirely because we are no longer using the old ATR algorithm for excluding files in RAT checks. Any new bugs will be new bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3702779393
The choice between ATR and RAT checks was added in 874b60ca3cea42cb311525d0cdb5c45d2870f2a9, closing #439. Related issue #296 is now tracked here. It points out a bug in how `.rat-excludes` are parsed in artifacts. We are going to update the way that RAT works in ATR, and that work may cover several issues including the present one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3708464178
@sbp I guess it wasn't clear what this request was for. I specifically am requesting that there be a UX way to specify whatever excludes apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3481882290
> We currently use [gitignore_parser](https://github.com/mherrmann/gitignore_parser) to match Source artifact paths and Binary artifact paths. Should the Source excludes patterns and Binary excludes patterns configuration options also use gitignore_parser?
Good question. Some research is needed into what the Creadur project thinks and whether or not the actual patterns used are usually simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #274:
URL: https://github.com/apache/tooling-trusted-releases/issues/274#issuecomment-3693239256
> These align with _Source artifact paths_ and _Binary artifact paths_.
We've noticed a logical problem with having both of these. We must drop _Binary artifact paths_. That way we automatically have two sets of artifacts with no intersections and no membership in both sets.
We still need both of these for the two types of checks. Add in the choice between `ATR` and `RAT` for source artifacts and the answer is clear that the pattern type for source checks should follow the check box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #274: New compose project options for license check excludes
URL: https://github.com/apache/tooling-trusted-releases/issues/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] New compose project options for license check excludes (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #274: New compose project options for license check excludes
URL: https://github.com/apache/tooling-trusted-releases/issues/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org