[GitHub] [ofbiz-framework] florianMo commented on a diff in pull request #548: Improved: Use FlexibleStringExpander for disabled attribute on fields

[GitBox <gi...@apache.org>]

florianMo commented on code in PR #548:
URL: https://github.com/apache/ofbiz-framework/pull/548#discussion_r989212390


##########
framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java:
##########
@@ -2738,25 +2745,30 @@ public ModelForm getModelGrid(Map<String, Object> context) {
      */
     public static class HiddenField extends FieldInfo {
         private final FlexibleStringExpander value;
+        private final FlexibleStringExpander disabled;

Review Comment:
   It's not really common but you can imagine to have a `<input type="hidden" disabled />`, which is valid I think, according to the spec (this is why I added this field on `HiddenField`, to be complete). It renders as an invisible and not submitted field. Not very useful (event if I can imagine use cases where this could be handy), but since you can do it in HTML I thought we should support it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org