You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2022/09/19 17:01:30 UTC
[GitHub] [ambari] jojochuang opened a new pull request, #3367: AMBARI-25733 Make JDK8 the minimum requirement
jojochuang opened a new pull request, #3367:
URL: https://github.com/apache/ambari/pull/3367
## What changes were proposed in this pull request?
Force JDK8 syntax and produce JDK8 classes.
## How was this patch tested?
existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 commented on a diff in pull request #3367: AMBARI-25733 Make JDK8 the minimum requirement
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #3367:
URL: https://github.com/apache/ambari/pull/3367#discussion_r982620773
##########
ambari-serviceadvisor/pom.xml:
##########
@@ -104,7 +104,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.2</version>
<configuration>
- <source>1.7</source>
+ <source>${jdk.version}</source>
<target>1.7</target>
Review Comment:
Why we keep using 1.7 here as target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 merged pull request #3367: AMBARI-25733 Make JDK8 the minimum requirement
Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #3367:
URL: https://github.com/apache/ambari/pull/3367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 commented on a diff in pull request #3367: AMBARI-25733 Make JDK8 the minimum requirement
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #3367:
URL: https://github.com/apache/ambari/pull/3367#discussion_r982620773
##########
ambari-serviceadvisor/pom.xml:
##########
@@ -104,7 +104,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.2</version>
<configuration>
- <source>1.7</source>
+ <source>${jdk.version}</source>
<target>1.7</target>
Review Comment:
Why we use 1.7 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] jojochuang commented on a diff in pull request #3367: AMBARI-25733 Make JDK8 the minimum requirement
Posted by GitBox <gi...@apache.org>.
jojochuang commented on code in PR #3367:
URL: https://github.com/apache/ambari/pull/3367#discussion_r982628601
##########
ambari-serviceadvisor/pom.xml:
##########
@@ -104,7 +104,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.2</version>
<configuration>
- <source>1.7</source>
+ <source>${jdk.version}</source>
<target>1.7</target>
Review Comment:
Good catch. I'll update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
[GitHub] [ambari] kevinw66 commented on pull request #3367: AMBARI-25733 Make JDK8 the minimum requirement
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #3367:
URL: https://github.com/apache/ambari/pull/3367#issuecomment-1261828436
Tested rebuild Ambari, reinstall cluster, everything looks good with this upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org