[jira] Commented: (HADOOP-4408) FsAction operations shouldn't create new Objects

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639274#action_12639274 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-4408:
------------------------------------------------

+1 patch looks good.

> FsAction operations shouldn't create new Objects
> ------------------------------------------------
>
>                 Key: HADOOP-4408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.16.0
>            Reporter: Chris Douglas
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: 4408-0.patch
>
>
> FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.