[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3320: HIVE-26261: Fix some issues with Spark engine removal

[GitBox <gi...@apache.org>]

kgyrtkirk commented on code in PR #3320:
URL: https://github.com/apache/hive/pull/3320#discussion_r882427374


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -158,6 +158,15 @@ private static boolean isDeferredAuthView(Table t){
     if (TableType.MATERIALIZED_VIEW.name().equals(tableType) || TableType.VIRTUAL_VIEW.name().equals(tableType)) {
       isView = true;
     }
+    if (isView) {
+      Map<String, String> params = t.getParameters();
+      if (params != null && params.containsKey(authorizedKeyword)) {

Review Comment:
   nice; so HIVE-25695 effectively mangled the [original condition to be spark dependent](https://github.com/apache/hive/commit/e61460b36178de3d8f2ddb28ad3f03902a34c3a8#diff-b1bce663288d98098d8aaa474ad0694d43484b0cd1977a788dc9f6c6f7fae4d0R163)...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org