You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Zhi Hong Yang <zh...@cn.ibm.com> on 2013/01/18 09:35:49 UTC
Re: Review Request: Variable Substitution should support EL syntax
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8184/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 8:35 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
Changes
-------
When there is variable can not be resolved by shindig EL, it will throw PropertyNotFound Exception in gadget renderring, igore this exception to continue the gadget rendering.
Description
-------
Copied from https://reviews.apache.org/r/6695/
The OpenSocial 2.0 specification now states that the old way of doing variable subsitution is now deprecated in favor of using EL syntax. Add that support to Shindig.
For example, Gadget developer should be able to to use EL syntax to
1. Calculate value like ${1+2}
2. get user preference values anywhere in the gadget XML by ${UserPrefs.xxx}
This addresses bug shindig-1588.
https://issues.apache.org/jira/browse/shindig-1588
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ELInGadgetDemo.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java 1417305
Diff: https://reviews.apache.org/r/8184/diff/
Testing
-------
Upload a Test Gadget with this patch
Thanks,
Zhi Hong Yang
Re: Review Request: Variable Substitution should support EL syntax
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8184/#review15510
-----------------------------------------------------------
This review is still open, could you please set the status to submitted?
- Dan Dumont
On Jan. 18, 2013, 8:38 a.m., Zhi Hong Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8184/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 8:38 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> Copied from https://reviews.apache.org/r/6695/
>
> The OpenSocial 2.0 specification now states that the old way of doing variable subsitution is now deprecated in favor of using EL syntax. Add that support to Shindig.
>
>
> For example, Gadget developer should be able to to use EL syntax to
> 1. Calculate value like ${1+2}
> 2. get user preference values anywhere in the gadget XML by ${UserPrefs.xxx}
>
>
> This addresses bug shindig-1588.
> https://issues.apache.org/jira/browse/shindig-1588
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ELInGadgetDemo.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json 1417305
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1417305
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java 1417305
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java 1417305
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java 1417305
>
> Diff: https://reviews.apache.org/r/8184/diff/
>
>
> Testing
> -------
>
> Upload a Test Gadget with this patch
>
>
> Thanks,
>
> Zhi Hong Yang
>
>
Re: Review Request: Variable Substitution should support EL syntax
Posted by Zhi Hong Yang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8184/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 8:38 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
Description
-------
Copied from https://reviews.apache.org/r/6695/
The OpenSocial 2.0 specification now states that the old way of doing variable subsitution is now deprecated in favor of using EL syntax. Add that support to Shindig.
For example, Gadget developer should be able to to use EL syntax to
1. Calculate value like ${1+2}
2. get user preference values anywhere in the gadget XML by ${UserPrefs.xxx}
This addresses bug shindig-1588.
https://issues.apache.org/jira/browse/shindig-1588
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ELInGadgetDemo.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java 1417305
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java 1417305
Diff: https://reviews.apache.org/r/8184/diff/
Testing
-------
Upload a Test Gadget with this patch
Thanks,
Zhi Hong Yang