You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/12 07:13:01 UTC
[GitHub] [arrow] kiszk opened a new pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
kiszk opened a new pull request #7938:
URL: https://github.com/apache/arrow/pull/7938
This PR adds a new test job for big-endian Java environment to TravisCI. It still keeps as
```
allow_failures:
- arch: s390x
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-703388481
Yes.
But I want to confirm that this still works with the latest master before we merge.
@kiszk Could you rebase this on the latest master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-703381572
Yes, I think so. I'd still like to update the contributor guidelines to make it clear what the level of support we are aiming for in each language (I hope to get to it tonight but if I don't it might take me a few days), but I think CI should be harmless. @kou it looks like you are happy with this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-703400730
@emkornfield @kou Thank you. I want to merge only this PR for CI. We should still hold off other PRs.
I rebased with master branch and confirmed it works well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#discussion_r479554130
##########
File path: java/pom.xml
##########
@@ -193,7 +193,7 @@
<target>1.8</target>
<maxmem>2048m</maxmem>
<useIncrementalCompilation>false</useIncrementalCompilation>
- <fork>true</fork>
+ <fork>false</fork>
Review comment:
Do we still need this?
##########
File path: ci/scripts/java_build.sh
##########
@@ -23,9 +23,68 @@ source_dir=${1}/java
cpp_build_dir=${2}/cpp/${ARROW_BUILD_TYPE:-debug}
with_docs=${3:-false}
-mvn="mvn -B -DskipTests -Drat.skip=true -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
-# Use `2 * ncores` threads
-mvn="${mvn} -T 2C"
+if [[ "$(uname -s)" == "Linux" ]] && [[ "$(uname -m)" == "s390x" ]]; then
+ # Since some files for s390_64 are not available at maven central,
+ # download pre-build files from bintray and install them explicitly
+ mvn_install="mvn install:install-file"
+ wget="wget"
+ bintray_base_url="https://dl.bintray.com/apache/arrow"
+
+ bintray_dir="flatc-binary"
+ group="com.github.icexelloss"
+ artifact="flatc-linux-s390_64"
+ ver="1.9.0"
+ extension="exe"
+ target=${artifact}-${ver}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+
+ bintray_dir="protoc-binary"
+ group="com.google.protobuf"
+ artifact="protoc"
+ ver="3.7.1"
+ classifier="linux-s390_64"
+ extension="exe"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+ # protoc requires libprotoc.so.18
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/libprotoc.so.18
+ export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:$(pwd)
+
+ bintray_dir="protoc-gen-grpc-java-binary"
+ group="io.grpc"
+ artifact="protoc-gen-grpc-java"
+ ver="1.30.2"
+ classifier="linux-s390_64"
+ extension="exe"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+
+ bintray_dir="netty-binary"
+ group="io.netty"
+ artifact="netty-transport-native-unix-common"
+ ver="4.1.48.Final"
+ classifier="linux-s390_64"
+ extension="jar"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+ artifact="netty-transport-native-epoll"
+ extension="jar"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+
+ # Use `2 * ncores` threads
+ mvn_options="-T 2C -Dmaven.compiler.verbose=true"
Review comment:
Can we remove `-Dmaven.compiler.verbose=true` and remove the `else` clause?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-672681198
https://issues.apache.org/jira/browse/ARROW-9701
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on a change in pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#discussion_r479583338
##########
File path: java/pom.xml
##########
@@ -193,7 +193,7 @@
<target>1.8</target>
<maxmem>2048m</maxmem>
<useIncrementalCompilation>false</useIncrementalCompilation>
- <fork>true</fork>
+ <fork>false</fork>
Review comment:
No, use the original setting. Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-703045578
@emkornfield @kou Is it ok to merge this PR now? Or, do we still hold off for a while?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#discussion_r469565710
##########
File path: .travis.yml
##########
@@ -81,24 +137,6 @@ before_install:
install:
- pip3 install -e dev/archery[docker]
-script:
Review comment:
How about using a common `script` for all jobs like the following?
```diff
diff --git a/.travis.yml b/.travis.yml
index fa5d84c82..551d0a029 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -47,15 +47,23 @@ jobs:
env:
ARCH: s390x
ARROW_CI_MODULES: "CPP"
- ARROW_FLIGHT: "ON"
- ARROW_PARQUET: "OFF"
DOCKER_IMAGE_ID: ubuntu-cpp
- PARQUET_BUILD_EXAMPLES: "OFF"
- PARQUET_BUILD_EXECUTABLES: "OFF"
- Protobuf_SOURCE: "BUNDLED"
+ DOCKER_RUN_ARGS: >-
+ -e ARROW_FLIGHT=ON
+ -e ARROW_PARQUET=OFF
+ -e PARQUET_BUILD_EXAMPLES=OFF
+ -e PARQUET_BUILD_EXECUTABLES=OFF
+ -e Protobuf_SOURCE=BUNDLED
+ -e cares_SOURCE=BUNDLED
+ -e gRPC_SOURCE=BUNDLED
UBUNTU: "20.04"
- cares_SOURCE: "BUNDLED"
- gRPC_SOURCE: "BUNDLED"
+ - name: "Java on s390x"
+ os: linux
+ arch: s390x
+ env:
+ ARCH: s390x
+ ARROW_CI_MODULES: "JAVA"
+ DOCKER_IMAGE_ID: debian-java
allow_failures:
- arch: s390x
@@ -89,13 +97,7 @@ script:
ulimit -c unlimited || :
- |
archery docker run \
- -e ARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \
- -e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
- -e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:-ON} \
- -e PARQUET_BUILD_EXECUTABLES=${PARQUET_BUILD_EXECUTABLES:-ON} \
- -e Protobuf_SOURCE=${Protobuf_SOURCE:-} \
- -e cares_SOURCE=${cares_SOURCE:-} \
- -e gRPC_SOURCE=${gRPC_SOURCE:-} \
+ ${DOCKER_RUN_ARGS} \
--volume ${PWD}/build:/build \
${DOCKER_IMAGE_ID}
```
##########
File path: .travis.yml
##########
@@ -56,6 +74,44 @@ jobs:
UBUNTU: "20.04"
cares_SOURCE: "BUNDLED"
gRPC_SOURCE: "BUNDLED"
+ script:
+ - sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ # This isn't allowed on Travis CI:
+ # /home/travis/.travis/functions: line 109: ulimit: core file size: cannot modify limit: Operation not permitted
+ - |
+ ulimit -c unlimited || :
+ - |
+ archery docker run \
+ -e ARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \
+ -e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
+ -e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:-ON} \
+ -e PARQUET_BUILD_EXECUTABLES=${PARQUET_BUILD_EXECUTABLES:-ON} \
+ -e Protobuf_SOURCE=${Protobuf_SOURCE:-} \
+ -e cares_SOURCE=${cares_SOURCE:-} \
+ -e gRPC_SOURCE=${gRPC_SOURCE:-} \
+ --volume ${PWD}/build:/build \
+ ${DOCKER_IMAGE_ID}
+
+ - name: "Java on s390x"
+ os: linux
+ arch: s390x
+ env:
+ ARCH: s390x
+ ARROW_CI_MODULES: "JAVA"
+ DOCKER_IMAGE_ID: debian-java
+ UBUNTU: "20.04"
Review comment:
This is needless because we don't use Ubuntu based docker image.
##########
File path: ci/scripts/java_build.sh
##########
@@ -23,6 +23,61 @@ source_dir=${1}/java
cpp_build_dir=${2}/cpp/${ARROW_BUILD_TYPE:-debug}
with_docs=${3:-false}
+if [[ "$(uname -s)" == "Linux" ]] && [[ "$(uname -m)" == "s390x" ]]; then
+ # Since some files for s390_64 are not available at maven central,
+ # download pre-build files from bintray and install them explicitly
+ mvn_install="mvn install:install-file"
+ wget="wget"
+ bintray_base_url="https://dl.bintray.com/apache/arrow"
+
+ bintray_dir="flatc-binary"
+ grp="com.github.icexelloss"
+ artifact="flatc-linux-s390_64"
+ ver="1.9.0"
+ extension="exe"
+ target=${artifact}-${ver}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${grp} -DartifactId=${artifact} -Dversion=${ver} -Dpackaging=${extension} -Dfile=`pwd`/${target}
+
+ bintray_dir="protoc-binary"
+ grp="com.google.protobuf"
+ artifact="protoc"
+ ver="3.7.1"
+ cls="linux-s390_64"
Review comment:
```suggestion
classifier="linux-s390_64"
```
##########
File path: ci/scripts/java_build.sh
##########
@@ -23,6 +23,61 @@ source_dir=${1}/java
cpp_build_dir=${2}/cpp/${ARROW_BUILD_TYPE:-debug}
with_docs=${3:-false}
+if [[ "$(uname -s)" == "Linux" ]] && [[ "$(uname -m)" == "s390x" ]]; then
+ # Since some files for s390_64 are not available at maven central,
+ # download pre-build files from bintray and install them explicitly
+ mvn_install="mvn install:install-file"
+ wget="wget"
+ bintray_base_url="https://dl.bintray.com/apache/arrow"
+
+ bintray_dir="flatc-binary"
+ grp="com.github.icexelloss"
Review comment:
```suggestion
group="com.github.icexelloss"
```
##########
File path: ci/scripts/java_build.sh
##########
@@ -23,6 +23,61 @@ source_dir=${1}/java
cpp_build_dir=${2}/cpp/${ARROW_BUILD_TYPE:-debug}
with_docs=${3:-false}
+if [[ "$(uname -s)" == "Linux" ]] && [[ "$(uname -m)" == "s390x" ]]; then
+ # Since some files for s390_64 are not available at maven central,
+ # download pre-build files from bintray and install them explicitly
+ mvn_install="mvn install:install-file"
+ wget="wget"
+ bintray_base_url="https://dl.bintray.com/apache/arrow"
+
+ bintray_dir="flatc-binary"
+ grp="com.github.icexelloss"
+ artifact="flatc-linux-s390_64"
+ ver="1.9.0"
+ extension="exe"
+ target=${artifact}-${ver}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${grp} -DartifactId=${artifact} -Dversion=${ver} -Dpackaging=${extension} -Dfile=`pwd`/${target}
Review comment:
Generally, `$(...)` is preferred than `` `...` ``:
```suggestion
${mvn_install} -DgroupId=${grp} -DartifactId=${artifact} -Dversion=${ver} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
```
##########
File path: .travis.yml
##########
@@ -56,6 +74,44 @@ jobs:
UBUNTU: "20.04"
cares_SOURCE: "BUNDLED"
gRPC_SOURCE: "BUNDLED"
+ script:
+ - sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ # This isn't allowed on Travis CI:
+ # /home/travis/.travis/functions: line 109: ulimit: core file size: cannot modify limit: Operation not permitted
+ - |
+ ulimit -c unlimited || :
+ - |
+ archery docker run \
+ -e ARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \
+ -e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
+ -e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:-ON} \
+ -e PARQUET_BUILD_EXECUTABLES=${PARQUET_BUILD_EXECUTABLES:-ON} \
+ -e Protobuf_SOURCE=${Protobuf_SOURCE:-} \
+ -e cares_SOURCE=${cares_SOURCE:-} \
+ -e gRPC_SOURCE=${gRPC_SOURCE:-} \
+ --volume ${PWD}/build:/build \
+ ${DOCKER_IMAGE_ID}
+
+ - name: "Java on s390x"
+ os: linux
+ arch: s390x
+ env:
+ ARCH: s390x
+ ARROW_CI_MODULES: "JAVA"
+ DOCKER_IMAGE_ID: debian-java
+ UBUNTU: "20.04"
+ script:
+ - sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ # This isn't allowed on Travis CI:
+ # /home/travis/.travis/functions: line 109: ulimit: core file size: cannot modify limit: Operation not permitted
+ - |
+ ulimit -c unlimited || :
+ - |
+ archery docker run \
+ -e ARCH=${ARCH} \
Review comment:
This is needless because `ARCH` is already passed as environment variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-703403823
Thanks.
I'll merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#issuecomment-682259059
@kou Thank you. Now, a TravisCI job is finished correctly with many failures. Could you review this again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on a change in pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #7938:
URL: https://github.com/apache/arrow/pull/7938#discussion_r479583274
##########
File path: ci/scripts/java_build.sh
##########
@@ -23,9 +23,68 @@ source_dir=${1}/java
cpp_build_dir=${2}/cpp/${ARROW_BUILD_TYPE:-debug}
with_docs=${3:-false}
-mvn="mvn -B -DskipTests -Drat.skip=true -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
-# Use `2 * ncores` threads
-mvn="${mvn} -T 2C"
+if [[ "$(uname -s)" == "Linux" ]] && [[ "$(uname -m)" == "s390x" ]]; then
+ # Since some files for s390_64 are not available at maven central,
+ # download pre-build files from bintray and install them explicitly
+ mvn_install="mvn install:install-file"
+ wget="wget"
+ bintray_base_url="https://dl.bintray.com/apache/arrow"
+
+ bintray_dir="flatc-binary"
+ group="com.github.icexelloss"
+ artifact="flatc-linux-s390_64"
+ ver="1.9.0"
+ extension="exe"
+ target=${artifact}-${ver}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+
+ bintray_dir="protoc-binary"
+ group="com.google.protobuf"
+ artifact="protoc"
+ ver="3.7.1"
+ classifier="linux-s390_64"
+ extension="exe"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+ # protoc requires libprotoc.so.18
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/libprotoc.so.18
+ export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:$(pwd)
+
+ bintray_dir="protoc-gen-grpc-java-binary"
+ group="io.grpc"
+ artifact="protoc-gen-grpc-java"
+ ver="1.30.2"
+ classifier="linux-s390_64"
+ extension="exe"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+
+ bintray_dir="netty-binary"
+ group="io.netty"
+ artifact="netty-transport-native-unix-common"
+ ver="4.1.48.Final"
+ classifier="linux-s390_64"
+ extension="jar"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+ artifact="netty-transport-native-epoll"
+ extension="jar"
+ target=${artifact}-${ver}-${classifier}.${extension}
+ ${wget} ${bintray_base_url}/${bintray_dir}/${ver}/${target}
+ ${mvn_install} -DgroupId=${group} -DartifactId=${artifact} -Dversion=${ver} -Dclassifier=${classifier} -Dpackaging=${extension} -Dfile=$(pwd)/${target}
+
+ # Use `2 * ncores` threads
+ mvn_options="-T 2C -Dmaven.compiler.verbose=true"
Review comment:
sure, done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI
Posted by GitBox <gi...@apache.org>.
kou closed pull request #7938:
URL: https://github.com/apache/arrow/pull/7938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org