You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/05 15:09:47 UTC

[GitHub] [arrow] pachamaltese opened a new pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

pachamaltese opened a new pull request #9893:
URL: https://github.com/apache/arrow/pull/9893


   fixes merge problem in https://github.com/apache/arrow/pull/9880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#issuecomment-813605809


   https://issues.apache.org/jira/browse/ARROW-11766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608710862



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       so, I just keep 
   ```
   feather.R:#' @param ... additional parameters, passed to [FeatherReader$create()][FeatherReader]
   ```
   or I move to
   ```
   #' @param ... additional parameters, passed to the internal function
   #' `make_readable_file()`
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608705293



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       ~~~`FeatherReader` is an exported object with a docs entry, so this link will work fine. There is no need to change the `@param ...` entry.~~~ Correction: See now that you're passing `...` to a different internal function. In that case, I think putting the function name in backticks without a link is good 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608705293



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       ~~`FeatherReader` is an exported object with a docs entry, so this link will work fine. There is no need to change the `@param ...` entry.~~ Correction: I see now that you're passing `...` to a different internal function. In that case, I think putting the function name in backticks without a link is good 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607395443



##########
File path: r/R/util.R
##########
@@ -86,3 +86,16 @@ all_names <- function(expr) {
 is_constant <- function(expr) {
   length(all_vars(expr)) == 0
 }
+
+read_compressed_error <- function(e) {
+  e <- as.character(e)
+  compression <- sub(".*Support for codec '(.*)'.*", "\\1", e)

Review comment:
       I still think that this function is problematic because it assumes that the only error you could get is about a codec. To illustrate:
   
   ```
   > tryCatch(stop("BANG BANG"), error = arrow:::read_compressed_error)
   Error: Unsupported compressed format Error in doTryCatch(return(expr), name, parentenv, handler): BANG BANG
   
   Try setting the environment variable LIBARROW_MINIMAL=false and reinstalling
   for a more complete installation (including Error in doTryCatch(return(expr), name, parentenv, handler): BANG BANG
   ) or setting
   ARROW_WITH_ERROR IN DOTRYCATCH(RETURN(EXPR), NAME, PARENTENV, HANDLER): BANG BANG
   =ON and reinstalling to enable support for this codec.
   ```
   
   You may be interested to compare with how I did something similar in https://github.com/apache/arrow/pull/9899/files#diff-f6235d4767fc4a7ee1bb726d816b9742ef0bc07503dceb678fd3bc55ee15454bR90-R96




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608302330



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       old:
   ```
   csv.R:#' - `...` additional parameters.
   feather.R:#' @param ... additional parameters, passed to [FeatherReader$create()][FeatherReader]
   ```
   
   new:
   ```
   csv.R:#' - `...` additional parameters.
   feather.R:#' @param ... additional parameters.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607344455



##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
 })
 
 unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+

Review comment:
       There should at least be a test for all lines of code you added. I don't see any parquet tests.
   
   Also, you might want to test what happens if you pass an invalid file (like, what if you did `read_feather(parquet_file)`?)

##########
File path: r/R/parquet.R
##########
@@ -52,10 +52,16 @@ read_parquet <- function(file,
     schema <- reader$GetSchema()
     names <- names(schema)
     indices <- match(vars_select(names, !!col_select), names) - 1L
-    tab <- reader$ReadTable(indices)
+    tab <- tryCatch(
+      reader$ReadTable(indices),
+      error = function(e) { read_compressed_error(e) }

Review comment:
       ```suggestion
         error = read_compressed_error
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607396622



##########
File path: r/R/feather.R
##########
@@ -147,14 +147,17 @@ read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
     file <- make_readable_file(file)
     on.exit(file$close())
   }
-  reader <- FeatherReader$create(file, ...)
+  reader <- FeatherReader$create(file)

Review comment:
       @jonkeane yes! it's intentional




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608160062



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       Thanks for moving these `...`. You should also update the docs above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607407735



##########
File path: r/R/feather.R
##########
@@ -147,14 +147,17 @@ read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
     file <- make_readable_file(file)
     on.exit(file$close())
   }
-  reader <- FeatherReader$create(file, ...)
+  reader <- FeatherReader$create(file)

Review comment:
       for example, from https://github.com/apache/arrow/pull/9756/files
   I still could still pass a mmap = TRUE to FileCreate from read_feather, so the ... is probably valuable in this context




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607370161



##########
File path: r/R/parquet.R
##########
@@ -52,10 +52,16 @@ read_parquet <- function(file,
     schema <- reader$GetSchema()
     names <- names(schema)
     indices <- match(vars_select(names, !!col_select), names) - 1L
-    tab <- reader$ReadTable(indices)
+    tab <- tryCatch(
+      reader$ReadTable(indices),
+      error = function(e) { read_compressed_error(e) }

Review comment:
       I've applied the same change to all similar lines in this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608716359



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       The latter 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607400618



##########
File path: r/R/feather.R
##########
@@ -147,14 +147,17 @@ read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
     file <- make_readable_file(file)
     on.exit(file$close())
   }
-  reader <- FeatherReader$create(file, ...)
+  reader <- FeatherReader$create(file)

Review comment:
       No, you don't need to re-add it since we took all of those out, but if this is the only place the `...` is used in this function, we should adjust its signature + docs too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608705293



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       `FeatherReader` is an exported object with a docs entry, so this link will work fine. There is no need to change the `@param ...` entry.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607396109



##########
File path: r/R/feather.R
##########
@@ -147,14 +147,17 @@ read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
     file <- make_readable_file(file)
     on.exit(file$close())
   }
-  reader <- FeatherReader$create(file, ...)
+  reader <- FeatherReader$create(file)

Review comment:
       Is the dropping of `...` here intentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608705293



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       ~~`FeatherReader` is an exported object with a docs entry, so this link will work fine. There is no need to change the `@param ...` entry.~~ Correction: See now that you're passing `...` to a different internal function. In that case, I think putting the function name in backticks without a link is good 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608302330



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       old:
   ```
   csv.R:#' - `...` additional parameters.
   feather.R:#' @param ... additional parameters, passed to the internal function
   ```
   
   new:
   ```
   csv.R:#' - `...` additional parameters.
   feather.R:#' @param ... additional parameters.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607363061



##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
 })
 
 unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+
+test_that("Error messages are shown when the compression algorithm lz4 is not found", {
+  if (codec_is_available("lz4")) {
+    d <- read_feather(ft_file)
+    expect_is(d, "data.frame")
+  } else {
+    expect_error(
+      read_feather(ft_file),
+      "Unsupported compressed format"

Review comment:
       You may want to assert the whole message here since you're doing some rather complex string manipulation to assemble it.

##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
 })
 
 unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+

Review comment:
       Not duplication, your code changes in parquet.R are not tested without them




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607388600



##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
 })
 
 unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+

Review comment:
       In chatting with Neal about this, I had originally commented on the parquet test you added in the first PR that it wasn't being triggered. It wasn't ever triggered on the crossbow job that you were testing on that PR, but it turns out that that branch will be triggered in a different crossbow test that I had forgotten about: https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L1609-L1613. SO you'll want to run both of those crossbow builds when you're testing this to ensure that you're getting the messages you expect.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607396921



##########
File path: r/R/feather.R
##########
@@ -147,14 +147,17 @@ read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
     file <- make_readable_file(file)
     on.exit(file$close())
   }
-  reader <- FeatherReader$create(file, ...)
+  reader <- FeatherReader$create(file)

Review comment:
       should I re-add it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608705293



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       ~~`FeatherReader` is an exported object with a docs entry, so this link will work fine. There is no need to change the `@param ...` entry.~~ Correction: I see now that you're passing `...` to a different function, which _is_ internal. In that case, I think putting the function name in backticks without a link is good 👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608302045



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       not sure how to refer to an internal function in Rd linking, so I just changed to "additional parameters." for now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pachamaltese commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607359378



##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
 })
 
 unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+

Review comment:
       thanks, I'll re-add those since I thought it was a "duplication"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607401144



##########
File path: r/R/feather.R
##########
@@ -147,14 +147,17 @@ read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
     file <- make_readable_file(file)
     on.exit(file$close())
   }
-  reader <- FeatherReader$create(file, ...)
+  reader <- FeatherReader$create(file)

Review comment:
       The dots should be passed to `make_readable_file()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson closed pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #9893:
URL: https://github.com/apache/arrow/pull/9893


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r609128875



##########
File path: r/R/feather.R
##########
@@ -125,7 +125,8 @@ write_feather <- function(x,
 #'
 #' @inheritParams read_ipc_stream
 #' @inheritParams read_delim_arrow
-#' @param ... additional parameters, passed to [FeatherReader$create()][FeatherReader]
+#' @param ... additional parameters, passed to the internal function
+#' `make_readable_file()`

Review comment:
       It's internal but it's [documented](https://arrow.apache.org/docs/r/reference/make_readable_file.html) so we can link to it: 
   
   ```suggestion
   #' [make_readable_file()].
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608705293



##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
 #' }
 read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
   if (!inherits(file, "RandomAccessFile")) {
-    file <- make_readable_file(file)
+    file <- make_readable_file(file, ...)

Review comment:
       `FeatherReader` is an exported object with a docs entry, so this link will work fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org