You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by marti1125 <gi...@git.apache.org> on 2014/06/12 21:18:26 UTC
[GitHub] cordova-firefoxos pull request: delete foo file
GitHub user marti1125 opened a pull request:
https://github.com/apache/cordova-firefoxos/pull/14
delete foo file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marti1125/cordova-firefoxos CB-6832
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-firefoxos/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 82fc44d4f7be664668a04c723df77fbc7bf5a6bb
Author: Willy Aguirre <ma...@gmail.com>
Date: 2014-06-11T02:33:40Z
delete foo file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-firefoxos pull request: delete foo file
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-46247504
Did some basic manual testing and looks good. r+
I added a comment about the header licenses to [the issue you created](https://github.com/marti1125/cordova-firefoxos/issues/1)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-firefoxos pull request: delete foo file
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-46071557
Glad it wasn't needed. I'll do some testing and let you know. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-firefoxos pull request: delete foo file
Posted by marti1125 <gi...@git.apache.org>.
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-46077377
@rodms10 I made a test I didn't find any problem.
and about Update Fix header licenses, I don't know, what I do? :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-firefoxos pull request: delete foo file
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-firefoxos/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-firefoxos pull request: delete foo file
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/14#issuecomment-47009869
Looks good, thanks for working on this @marti1125! r+ @zalun, can you merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---