You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/10 13:48:04 UTC
[GitHub] [superset] 1nF0rmed opened a new issue #17051: [TODO] How should the we check the email validity?
1nF0rmed opened a new issue #17051:
URL: https://github.com/apache/superset/issues/17051
The TODO mentions that we need to check the validity of an email:
https://github.com/apache/superset/blob/ea49aa3d2d31d496531f1142fa6a1504b1fe997a/superset/reports/schemas.py#L108-L110
Does this mean the check will be for general email format validity(`someone@service.com`) or should it check if the email exists?
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #17051: [Alert&report] How should the we check the email validity?
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #17051:
URL: https://github.com/apache/superset/issues/17051#issuecomment-941442357
@dpgaspar 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #17051: [TODO] How should the we check the email validity?
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #17051:
URL: https://github.com/apache/superset/issues/17051#issuecomment-941442357
@lilykuang 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #17051: [TODO] How should the we check the email validity?
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #17051:
URL: https://github.com/apache/superset/issues/17051#issuecomment-941442357
@lilykuang 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #17051: [Alert&report] How should the we check the email validity?
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #17051:
URL: https://github.com/apache/superset/issues/17051#issuecomment-941442357
@dpgaspar 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org