You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2016/05/30 09:40:31 UTC

[GitHub] kafka pull request: MINOR: Avoid trace logging computation in `che...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/1449

    MINOR: Avoid trace logging computation in `checkEnoughReplicasReachOffset`

    `numAcks` is only used in the `trace` logging statement so it should be a `def` and not a `val`. Also took the chance to improve the code and documentation a little.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka minor-avoid-trace-logging-computation-in-partition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1449.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1449
    
----
commit 8fdf820e68053b3fe1170a38a9e167afb96caa37
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-05-30T09:37:40Z

    Avoid computing `numAcks` in `checkEnoughReplicasReachOffset` unless trace logging is enabled

commit e1a357e94339dbc8d5533649964d708d5770ce74
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-05-30T09:38:31Z

    Improve code style in `checkEnoughReplicasReachOffset` and `DelayedProduce.tryComplete`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: MINOR: Avoid trace logging computation in `checkEnoughRe...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---