You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xicm (via GitHub)" <gi...@apache.org> on 2023/03/13 03:14:23 UTC
[GitHub] [hudi] xicm opened a new pull request, #8163: [HUDI-5921] Partition path should be considered BucketIndexConcurrentFileWritesConflictResolutionStrategy
xicm opened a new pull request, #8163:
URL: https://github.com/apache/hudi/pull/8163
### Change Logs
When we do conflict detecting on BUCKET index table, we check bucketId to see if there is a conflict, for partitioned table, if two client write different partition but same bucketId, there will be a conflict, actually this case should not have conflict.
This pr check partition+bucketId to see if there is a conflict.
### Impact
none
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xicm commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1483810332
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1134812808
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java:
##########
@@ -78,7 +79,13 @@ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
final ConcurrentOperation thisOperation = new ConcurrentOperation(currentTxnOwnerInstant.get(), thisCommitMetadata.orElse(new HoodieCommitMetadata()));
instantStream.forEach(instant -> {
try {
- ConcurrentOperation otherOperation = new ConcurrentOperation(instant, table.getMetaClient());
+ ConcurrentOperation otherOperation;
+ if (resolutionStrategy.getClass().getName().equals(BucketIndexConcurrentFileWritesConflictResolutionStrategy.class.getName())) {
+ otherOperation = new ConcurrentOperation(instant, TimelineUtils.getCommitMetadata(instant,
+ reloadActiveTimeline ? table.getMetaClient().reloadActiveTimeline() : table.getActiveTimeline()));
+ } else {
Review Comment:
do we need to realod the timeline for each instant ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1482549640
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 6902f3376e10c37fd08b1388c87038385efb1012 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1477279441
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1465707858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* d4ec73317fa92bb5e144ffca302683b9293a630a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681)
* 57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xicm commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1147190800
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactHelpers.java:
##########
@@ -65,6 +66,7 @@ public HoodieCommitMetadata createCompactionMetadata(
metadata.addWriteStat(stat.getPartitionPath(), stat);
}
metadata.addMetadata(org.apache.hudi.common.model.HoodieCommitMetadata.SCHEMA_KEY, schema);
+ metadata.setOperationType(WriteOperationType.COMPACT);
Review Comment:
@danny0405 This change has nothing to do with this pr, but the problem exists, should I keep this line？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1477177735
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* a25bc8d72a404833b49cecd712c58e4217b241b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801)
* 2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1465877359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xicm commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1141641379
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java:
##########
@@ -78,7 +79,13 @@ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
final ConcurrentOperation thisOperation = new ConcurrentOperation(currentTxnOwnerInstant.get(), thisCommitMetadata.orElse(new HoodieCommitMetadata()));
instantStream.forEach(instant -> {
try {
- ConcurrentOperation otherOperation = new ConcurrentOperation(instant, table.getMetaClient());
+ ConcurrentOperation otherOperation;
+ if (resolutionStrategy.getClass().getName().equals(BucketIndexConcurrentFileWritesConflictResolutionStrategy.class.getName())) {
+ otherOperation = new ConcurrentOperation(instant, TimelineUtils.getCommitMetadata(instant,
+ reloadActiveTimeline ? table.getMetaClient().reloadActiveTimeline() : table.getActiveTimeline()));
+ } else {
Review Comment:
Thanks for the heads-up. It's no need to reload the timeline here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1482561459
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
}, {
"hash" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 6902f3376e10c37fd08b1388c87038385efb1012 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888)
* 7bb2b915a31acb05af30d6672fa755a4a1bc59ea UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1483836655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
}, {
"hash" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895",
"triggerID" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"triggerType" : "PUSH"
}, {
"hash" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15914",
"triggerID" : "1483810332",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 7bb2b915a31acb05af30d6672fa755a4a1bc59ea Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15914)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1475668364
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686)
* a25bc8d72a404833b49cecd712c58e4217b241b0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xicm commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1141647554
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactHelpers.java:
##########
@@ -65,6 +66,7 @@ public HoodieCommitMetadata createCompactionMetadata(
metadata.addWriteStat(stat.getPartitionPath(), stat);
}
metadata.addMetadata(org.apache.hudi.common.model.HoodieCommitMetadata.SCHEMA_KEY, schema);
+ metadata.setOperationType(WriteOperationType.COMPACT);
Review Comment:
When I run test in TestWriteMergeOnRead, I find compaction in flink doesn't add operationType to commit meta data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1476012808
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* a25bc8d72a404833b49cecd712c58e4217b241b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1465455121
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1141737924
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestBucketIndexConcurrentFileWritesConflictResolutionStrategy.java:
##########
@@ -111,6 +112,33 @@ public void testConcurrentWritesWithInterleavingSuccessfulCommit() throws Except
}
}
+ @Test
+ public void testConcurrentWritesWithDifferentPartition() throws Exception {
+ createCommit(HoodieActiveTimeline.createNewInstantTime());
+ HoodieActiveTimeline timeline = metaClient.getActiveTimeline();
+ // consider commits before this are all successful
+ Option<HoodieInstant> lastSuccessfulInstant = timeline.getCommitsTimeline().filterCompletedInstants().lastInstant();
+ // writer 1 starts
+ String currentWriterInstant = HoodieActiveTimeline.createNewInstantTime();
+ createInflightCommit(currentWriterInstant, HoodieTestDataGenerator.DEFAULT_SECOND_PARTITION_PATH);
+ // writer 2 starts and finishes
+ String newInstantTime = HoodieActiveTimeline.createNewInstantTime();
+ createCommit(newInstantTime);
+
+ Option<HoodieInstant> currentInstant = Option.of(new HoodieInstant(State.INFLIGHT, HoodieTimeline.COMMIT_ACTION, currentWriterInstant));
+ SimpleConcurrentFileWritesConflictResolutionStrategy strategy = new BucketIndexConcurrentFileWritesConflictResolutionStrategy();
+ HoodieCommitMetadata currentMetadata = createCommitMetadata(currentWriterInstant, HoodieTestDataGenerator.DEFAULT_SECOND_PARTITION_PATH);
+ timeline = timeline.reload();
+ List<HoodieInstant> candidateInstants = strategy.getCandidateInstants(timeline, currentInstant.get(), lastSuccessfulInstant).collect(
+ Collectors.toList());
+
+ // writer 1 conflicts with writer 2
+ Assertions.assertEquals(1, candidateInstants.size());
Review Comment:
> writer 1 conflicts with writer 2
I guess you meant not to conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1482571094
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
}, {
"hash" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895",
"triggerID" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 6902f3376e10c37fd08b1388c87038385efb1012 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888)
* 7bb2b915a31acb05af30d6672fa755a4a1bc59ea Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xicm commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1146010560
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java:
##########
@@ -78,7 +78,7 @@ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
final ConcurrentOperation thisOperation = new ConcurrentOperation(currentTxnOwnerInstant.get(), thisCommitMetadata.orElse(new HoodieCommitMetadata()));
instantStream.forEach(instant -> {
try {
- ConcurrentOperation otherOperation = new ConcurrentOperation(instant, table.getMetaClient());
+ ConcurrentOperation otherOperation = new ConcurrentOperation(instant, TimelineUtils.getCommitMetadata(instant, table.getActiveTimeline()));
if (resolutionStrategy.hasConflict(thisOperation, otherOperation)) {
Review Comment:
I think I find the reason. The instant may be compaction.request, in this case we can't use TimelineUtils.getCommitMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1465462327
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* d4ec73317fa92bb5e144ffca302683b9293a630a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1465458911
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* d4ec73317fa92bb5e144ffca302683b9293a630a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1465698908
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* d4ec73317fa92bb5e144ffca302683b9293a630a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681)
* 57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1142906925
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java:
##########
@@ -78,7 +78,7 @@ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
final ConcurrentOperation thisOperation = new ConcurrentOperation(currentTxnOwnerInstant.get(), thisCommitMetadata.orElse(new HoodieCommitMetadata()));
instantStream.forEach(instant -> {
try {
- ConcurrentOperation otherOperation = new ConcurrentOperation(instant, table.getMetaClient());
+ ConcurrentOperation otherOperation = new ConcurrentOperation(instant, TimelineUtils.getCommitMetadata(instant, table.getActiveTimeline()));
if (resolutionStrategy.hasConflict(thisOperation, otherOperation)) {
Review Comment:
Need to figure out why the original commit wrap the commit metadaat using `HoodieArchivedMetaEntry`, @n3nash can you give some clarification here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1475662187
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686)
* a25bc8d72a404833b49cecd712c58e4217b241b0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xicm commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1141647554
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactHelpers.java:
##########
@@ -65,6 +66,7 @@ public HoodieCommitMetadata createCompactionMetadata(
metadata.addWriteStat(stat.getPartitionPath(), stat);
}
metadata.addMetadata(org.apache.hudi.common.model.HoodieCommitMetadata.SCHEMA_KEY, schema);
+ metadata.setOperationType(WriteOperationType.COMPACT);
Review Comment:
When I run test in TestWriteMergeOnRead, I found compaction in flink doesn't add operationType to commit meta data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1482363884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821)
* 6902f3376e10c37fd08b1388c87038385efb1012 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1482859722
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
}, {
"hash" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895",
"triggerID" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 7bb2b915a31acb05af30d6672fa755a4a1bc59ea Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1465578273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* d4ec73317fa92bb5e144ffca302683b9293a630a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8163:
URL: https://github.com/apache/hudi/pull/8163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xicm commented on a diff in pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "xicm (via GitHub)" <gi...@apache.org>.
xicm commented on code in PR #8163:
URL: https://github.com/apache/hudi/pull/8163#discussion_r1141748370
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestBucketIndexConcurrentFileWritesConflictResolutionStrategy.java:
##########
@@ -111,6 +112,33 @@ public void testConcurrentWritesWithInterleavingSuccessfulCommit() throws Except
}
}
+ @Test
+ public void testConcurrentWritesWithDifferentPartition() throws Exception {
+ createCommit(HoodieActiveTimeline.createNewInstantTime());
+ HoodieActiveTimeline timeline = metaClient.getActiveTimeline();
+ // consider commits before this are all successful
+ Option<HoodieInstant> lastSuccessfulInstant = timeline.getCommitsTimeline().filterCompletedInstants().lastInstant();
+ // writer 1 starts
+ String currentWriterInstant = HoodieActiveTimeline.createNewInstantTime();
+ createInflightCommit(currentWriterInstant, HoodieTestDataGenerator.DEFAULT_SECOND_PARTITION_PATH);
+ // writer 2 starts and finishes
+ String newInstantTime = HoodieActiveTimeline.createNewInstantTime();
+ createCommit(newInstantTime);
+
+ Option<HoodieInstant> currentInstant = Option.of(new HoodieInstant(State.INFLIGHT, HoodieTimeline.COMMIT_ACTION, currentWriterInstant));
+ SimpleConcurrentFileWritesConflictResolutionStrategy strategy = new BucketIndexConcurrentFileWritesConflictResolutionStrategy();
+ HoodieCommitMetadata currentMetadata = createCommitMetadata(currentWriterInstant, HoodieTestDataGenerator.DEFAULT_SECOND_PARTITION_PATH);
+ timeline = timeline.reload();
+ List<HoodieInstant> candidateInstants = strategy.getCandidateInstants(timeline, currentInstant.get(), lastSuccessfulInstant).collect(
+ Collectors.toList());
+
+ // writer 1 conflicts with writer 2
+ Assertions.assertEquals(1, candidateInstants.size());
Review Comment:
The assert means there should be 1 candidate instant, I will update the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1477182054
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* a25bc8d72a404833b49cecd712c58e4217b241b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801)
* 2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1482357458
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821)
* 6902f3376e10c37fd08b1388c87038385efb1012 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8163: [HUDI-5921] Partition path should be considered in BucketIndexConcurrentFileWritesConflictResolutionStrategy
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8163:
URL: https://github.com/apache/hudi/pull/8163#issuecomment-1483811942
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6a26972e75f23b195c24cd51619f6409b42c95",
"triggerType" : "PUSH"
}, {
"hash" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15681",
"triggerID" : "d4ec73317fa92bb5e144ffca302683b9293a630a",
"triggerType" : "PUSH"
}, {
"hash" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15686",
"triggerID" : "57ac8ac9a3fdb3788646d3fc912d5e1c6693ff24",
"triggerType" : "PUSH"
}, {
"hash" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15801",
"triggerID" : "a25bc8d72a404833b49cecd712c58e4217b241b0",
"triggerType" : "PUSH"
}, {
"hash" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15821",
"triggerID" : "2f83d587b5f7bdaae0c907dfc20e4ce77e241a8f",
"triggerType" : "PUSH"
}, {
"hash" : "6902f3376e10c37fd08b1388c87038385efb1012",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15888",
"triggerID" : "6902f3376e10c37fd08b1388c87038385efb1012",
"triggerType" : "PUSH"
}, {
"hash" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895",
"triggerID" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"triggerType" : "PUSH"
}, {
"hash" : "7bb2b915a31acb05af30d6672fa755a4a1bc59ea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15914",
"triggerID" : "1483810332",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* fa6a26972e75f23b195c24cd51619f6409b42c95 UNKNOWN
* 7bb2b915a31acb05af30d6672fa755a4a1bc59ea Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15895) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15914)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org