You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2017/09/25 06:11:48 UTC
Review Request 62533: RANGER-1805: Code improvement to follow best
practices in js
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62533/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Mehul Parikh, and Velmurugan Periasamy.
Bugs: RANGER-1805
https://issues.apache.org/jira/browse/RANGER-1805
Repository: ranger
Description
-------
Javascript coding best practices.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/XAOverrides.js 5810d5d
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 3338633
security-admin/src/main/webapp/scripts/utils/XAEnums.js 164e939
security-admin/src/main/webapp/scripts/utils/XATemplateHelpers.js 785e2c2
security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js 1b1a4aa
security-admin/src/main/webapp/scripts/views/common/AddGroup.js 81fd901
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 92b8334
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js ab42b5c
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js e9d3675
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js c5dc053
security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js a385592
security-admin/src/main/webapp/templates/common/Footer_tmpl.html e3accb6
security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html 49be577
security-admin/src/main/webapp/templates/helpers/XAHelpers.js 1766880
security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html 2aaac43
security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html 31252af
security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html d79028e
security-admin/src/main/webapp/templates/users/GroupCreate_tmpl.html c387e68
security-admin/src/main/webapp/templates/users/UserCreate_tmpl.html 204e832
Diff: https://reviews.apache.org/r/62533/diff/1/
Testing
-------
Done overall basic UI testing which includes service, policy, user, group and permission modules.
Thanks,
Nitin Galave