You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "xwm1992 (via GitHub)" <gi...@apache.org> on 2023/05/05 09:50:10 UTC
[GitHub] [eventmesh] xwm1992 commented on a diff in pull request #3819: [ISSUE #3815]DelayRetryable and RetryContext can be refactored.
xwm1992 commented on code in PR #3819:
URL: https://github.com/apache/eventmesh/pull/3819#discussion_r1185902661
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/producer/SendMessageContext.java:
##########
@@ -123,13 +123,13 @@ public String toString() {
}
@Override
- public boolean retry() throws Exception {
+ public void retry() throws Exception {
if (eventMeshProducer == null) {
- return false;
+ log.error("Exception happends during retry. EventMeshProduceer is null.");
}
if (retryTimes > 0) { //retry once
- return false;
+ log.error("Exception happends during retry. The retryTimes > 0.");
Review Comment:
same as above
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/producer/SendMessageContext.java:
##########
@@ -123,13 +123,13 @@ public String toString() {
}
@Override
- public boolean retry() throws Exception {
+ public void retry() throws Exception {
if (eventMeshProducer == null) {
- return false;
+ log.error("Exception happends during retry. EventMeshProduceer is null.");
Review Comment:
here need add return in if block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org