You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/11/04 00:14:33 UTC

[jira] Created: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

use "pending ranges" abstraction in TokenMetadata
-------------------------------------------------

                 Key: CASSANDRA-525
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
             Project: Cassandra
          Issue Type: Sub-task
            Reporter: Jonathan Ellis
            Assignee: Jonathan Ellis
             Fix For: 0.5




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jaakko Laine updated CASSANDRA-525:
-----------------------------------

    Attachment: 0005-replace-mode-with-state_bootstrapping.txt

05
Replace MODE + token broadcasting with bootsrap token (STATE_BOOTSTRAPPING). This way one message should be enough for bootstrapping/normal transitions.


> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt, 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt, 0005-replace-mode-with-state_bootstrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-525:
-------------------------------------

    Attachment: 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt
                0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt
                0002-make-sortedtokens-passably-efficient.txt
                0001-CASSANDRA-525-cleanup.txt

> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt, 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-525:
-------------------------------------

    Attachment:     (was: 0002-make-sortedtokens-passably-efficient.txt)

> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt, 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-525:
-------------------------------------

    Attachment:     (was: 0001-CASSANDRA-525-cleanup.txt)

> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt, 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jaakko Laine (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jaakko Laine updated CASSANDRA-525:
-----------------------------------

    Attachment: 0004-use-bootstrap_node-in-bootsrapping.txt

04
Replace MODE gossiping with token gossiping (NODE_BOOTSTRAP_ID) during bootsrapping. MODE + NODE_ID broadcast is not atomic, so need to rely on one message to get all bootsrapping data.


> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773994#action_12773994 ] 

Jonathan Ellis commented on CASSANDRA-525:
------------------------------------------

Third try. :)

04
     onChange only ever sees one ApplicationState piece change at a time, so we perform a kind of state machine here.
     We are concerned with two events: knowing the token associated with an enpoint, and knowing its operation mode.
     Nodes can start in either bootstrap or normal mode, and from bootstrap mode can change mode to normal.
     A node in bootstrap mode needs to have pendingranges set in TokenMetadata; a node in normal mode
     should instead be part of the token ring.

03
    split out onJoin from onChange, so we can pass a single ApplicationState object to onChange
    to emphasize that it gets called once per AS
    rename ApplicationState.getState -> getValue


> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt, 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774591#action_12774591 ] 

Hudson commented on CASSANDRA-525:
----------------------------------

Integrated in Cassandra #251 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/251/])
    containing isBootstrapping and BootstrapTokenAddress information in TokenMetadata is the wrong level of abstraction.  Switch to pendingRanges instead.
patch by jbellis and Jaakko Laine for 
split out onJoin from onChange, so we can pass a single ApplicationState object to onChange to emphasize that it gets called once per AS; rename ApplicationState.getState -> getValue
patch by jbellis; reviewed by Jaakko Laine for 
make sortedtokens passably efficient
patch by jbellis; reviewed by Jaakko Laine for 
fix TODO in tokenmetadata (bootstrap tokens aren't part of the official ring now).  r/m redundant getNextEndPoint method in favor of getSuccessor
patch by jbellis; reviewed by Jaakko Laine for 


> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt, 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt, 0005-replace-mode-with-state_bootstrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-525:
-------------------------------------

    Attachment: 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt
                0002-make-sortedtokens-passably-efficient.txt
                0001-CASSANDRA-525-cleanup.txt

> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-525.
--------------------------------------

    Resolution: Fixed

committed w/ changes from 05

> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0003-split-out-onJoin-from-onChange-so-we-can-pass-a-singl.txt, 0004-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt, 0004-use-bootstrap_node-in-bootsrapping.txt, 0005-replace-mode-with-state_bootstrapping.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-525) use "pending ranges" abstraction in TokenMetadata

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773269#action_12773269 ] 

Jonathan Ellis commented on CASSANDRA-525:
------------------------------------------

03
    containing isBootstrapping and BootstrapTokenAddress information in TokenMetadata is the wrong level of abstraction.  Switch to pendingRanges instead.

02
    make sortedtokens passably efficient

01
    fix TODO in tokenmetadata (bootstrap tokens aren't part of the official ring now)
    r/m redundant getNextEndPoint method in favor of getSuccessor


> use "pending ranges" abstraction in TokenMetadata
> -------------------------------------------------
>
>                 Key: CASSANDRA-525
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-525
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-525-cleanup.txt, 0002-make-sortedtokens-passably-efficient.txt, 0003-containing-isBootstrapping-and-BootstrapTokenAddress-i.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.