You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by br...@apache.org on 2014/07/14 22:53:48 UTC
git commit: TS-1475: Fix leak in error case. Coverity #1022160
Repository: trafficserver
Updated Branches:
refs/heads/master 6114a8ce8 -> 1fc1f0359
TS-1475: Fix leak in error case. Coverity #1022160
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/1fc1f035
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/1fc1f035
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/1fc1f035
Branch: refs/heads/master
Commit: 1fc1f0359b854bc6d62d8f8e9deec239a82f1000
Parents: 6114a8c
Author: Brian Geffon <br...@apache.org>
Authored: Mon Jul 14 13:53:41 2014 -0700
Committer: Brian Geffon <br...@apache.org>
Committed: Mon Jul 14 13:53:41 2014 -0700
----------------------------------------------------------------------
proxy/ControlBase.cc | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/1fc1f035/proxy/ControlBase.cc
----------------------------------------------------------------------
diff --git a/proxy/ControlBase.cc b/proxy/ControlBase.cc
index 3335616..710f3be 100644
--- a/proxy/ControlBase.cc
+++ b/proxy/ControlBase.cc
@@ -647,6 +647,8 @@ ControlBase::ProcessModifiers(matcher_line * line_info) {
if (ME_UNKNOWN == err) {
_mods.push_back(mod);
--n_elts;
+ } else {
+ delete mod; // we still need to clean up because we didn't transfer ownership.
}
}