You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/26 15:56:33 UTC
[GitHub] [airflow] nuclearpinguin opened a new pull request #7547:
[AIRFLOW-6926] Fix Google Tasks operators return types and idempotency
nuclearpinguin opened a new pull request #7547: [AIRFLOW-6926] Fix Google Tasks operators return types and idempotency
URL: https://github.com/apache/airflow/pull/7547
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7547: [AIRFLOW-6926] Fix
Google Tasks operators return types and idempotency
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7547: [AIRFLOW-6926] Fix Google Tasks operators return types and idempotency
URL: https://github.com/apache/airflow/pull/7547#issuecomment-591984953
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7547?src=pr&el=h1) Report
> Merging [#7547](https://codecov.io/gh/apache/airflow/pull/7547?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/bb552b2d9fd595cc3eb1b3a2f637f29b814878d7?src=pr&el=desc) will **decrease** coverage by `0.31%`.
> The diff coverage is `92.85%`.
[](https://codecov.io/gh/apache/airflow/pull/7547?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7547 +/- ##
==========================================
- Coverage 86.86% 86.54% -0.32%
==========================================
Files 896 896
Lines 42638 42651 +13
==========================================
- Hits 37036 36912 -124
- Misses 5602 5739 +137
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7547?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...oviders/google/cloud/example\_dags/example\_tasks.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX3Rhc2tzLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/providers/google/cloud/operators/tasks.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy90YXNrcy5weQ==) | `99.14% <92.59%> (-0.86%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `71.31% <0%> (-11.3%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `86.51% <0%> (-1.83%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `90.9% <0%> (-0.4%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/airflow/pull/7547/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7547?src=pr&el=footer). Last update [bb552b2...2a1df2a](https://codecov.io/gh/apache/airflow/pull/7547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ad-m commented on a change in pull request #7547:
[AIRFLOW-6926] Fix Google Tasks operators return types and idempotency
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #7547: [AIRFLOW-6926] Fix Google Tasks operators return types and idempotency
URL: https://github.com/apache/airflow/pull/7547#discussion_r384689564
##########
File path: airflow/providers/google/cloud/example_dags/example_tasks.py
##########
@@ -39,7 +39,7 @@
timestamp = timestamp_pb2.Timestamp()
timestamp.FromDatetime(datetime.now() + timedelta(hours=12)) # pylint: disable=no-member
-LOCATION = "asia-east2"
+LOCATION = "europe-west1"
Review comment:
Why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7547: [AIRFLOW-6926] Fix
Google Tasks operators return types and idempotency
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7547: [AIRFLOW-6926] Fix Google Tasks operators return types and idempotency
URL: https://github.com/apache/airflow/pull/7547
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services