You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/06/04 16:37:12 UTC
Re: Review Request 33331: Added file headers section to the C++ style
guide.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33331/
-----------------------------------------------------------
(Updated June 4, 2015, 2:37 p.m.)
Review request for mesos.
Changes
-------
rebased
Repository: mesos-incubating
Description
-------
see summary.
Diffs (updated)
-----
docs/mesos-c++-style-guide.md 5dcbdad
Diff: https://reviews.apache.org/r/33331/diff/
Testing
-------
N/A
Thanks,
Till Toenshoff
Re: Review Request 33331: Added file headers section to the C++ style
guide.
Posted by Till Toenshoff <to...@me.com>.
> On June 4, 2015, 2:48 p.m., Joerg Schad wrote:
> > docs/mesos-c++-style-guide.md, line 198
> > <https://reviews.apache.org/r/33331/diff/2/?file=979108#file979108line198>
> >
> > Please make this a list item (same below).
> > <p>must or should?</p>
Makes sense indeed.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33331/#review86615
-----------------------------------------------------------
On June 4, 2015, 2:37 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33331/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 2:37 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 5dcbdad
>
> Diff: https://reviews.apache.org/r/33331/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 33331: Added file headers section to the C++ style
guide.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33331/#review86615
-----------------------------------------------------------
docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33331/#comment138668>
Please make this a list item (same below).
<p>must or should?</p>
docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/33331/#comment138669>
must or should?
- Joerg Schad
On June 4, 2015, 2:37 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33331/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 2:37 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 5dcbdad
>
> Diff: https://reviews.apache.org/r/33331/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Till Toenshoff
>
>