[jira] [Commented] (KAFKA-6820) Improve on StreamsMetrics Public APIs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800458#comment-16800458 ] 

ASF GitHub Bot commented on KAFKA-6820:
---------------------------------------

guozhangwang commented on pull request #6498: [DO NOT MERGE] KAFKA-6820: Refactor Stream Metrics
URL: https://github.com/apache/kafka/pull/6498
 
 
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve on StreamsMetrics Public APIs
> -------------------------------------
>
>                 Key: KAFKA-6820
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6820
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Priority: Major
>              Labels: needs-kip
>
> Our current `addLatencyAndThroughputSensor`, `addThroughputSensor` are not very well designed and hence not very user friendly to people to add their customized sensors. We could consider improving on this feature. Some related things to consider:
> 1. Our internal built-in metrics should be independent on these public APIs which are for user customized sensor only. See KAFKA-6819 for related description.
> 2. We could enforce the scopeName possible values, and well document on the sensor hierarchies that would be incurred from the function calls. In this way the library can help closing user's sensors automatically when the corresponding scope (store, task, thread, etc) is being de-constructed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)