[GitHub] [accumulo] keith-turner commented on a diff in pull request #2967: Update the new modify properties API to automatically retry on concurrent modification exception.

[GitBox <gi...@apache.org>]

keith-turner commented on code in PR #2967:
URL: https://github.com/apache/accumulo/pull/2967#discussion_r981587839


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1035,6 +1031,30 @@ public void modifyProperties(String tableName, final Consumer<Map<String,String>
     }
   }
 
+  @Override
+  public void modifyProperties(String tableName, final Consumer<Map<String,String>> mapMutator)

Review Comment:
   I would like to see Accumulo support async APIs.  I think that should be done with consideration of the entire API and looking at what APIs we want to add.  Not sure about doing that as a one off here.  Would need to create and manage a thread  or thread pool to do that here, which is another reason to consider it API wide maybe (maybe we want to allow passing in an executor for async APIs?)
   
   I would also like to explore making the read and write pipelines in the tserver and sserver asynchronous.  I think this could support more client connections per server and would be good for making them  more responsive in the case we had discussed in the past of having many sservers and few tservers.  It think it would be good to make the server pipelines async at the same time as adding async APIs to Accumulo so that the two could influence each other.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org