You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "kparzysz-quic (via GitHub)" <gi...@apache.org> on 2023/08/28 18:54:41 UTC

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #15595: [Runtime] Enhance PackedFunc Metaprogramming with `PackArgs`

kparzysz-quic commented on code in PR #15595:
URL: https://github.com/apache/tvm/pull/15595#discussion_r1307790075


##########
include/tvm/runtime/packed_func.h:
##########
@@ -1622,6 +1641,20 @@ inline TVMRetValue PackedFunc::operator()(Args&&... args) const {
   return rv;
 }
 
+template <int i, typename T>

Review Comment:
   This should be `size_t` not `int`.  Otherwise it fails to compile with clang.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org