You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/26 20:15:38 UTC

[GitHub] [solr-site] HoustonPutman opened a new pull request #35: Rename operator downloads page to artifacts.

HoustonPutman opened a new pull request #35:
URL: https://github.com/apache/solr-site/pull/35


   https://issues.apache.org/jira/browse/SOLR-15593
   
   This is done to simplify (and frankly fix)  the current htaccess rules that the download page name makes necessary.
   
   Will need to test this out locally and change the location in the Solr Operator documentation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr-site] uschindler commented on a change in pull request #35: Rename operator downloads page to artifacts.

Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #35:
URL: https://github.com/apache/solr-site/pull/35#discussion_r697312402



##########
File path: themes/solr/templates/htaccess.template
##########
@@ -71,7 +71,7 @@ RedirectMatch Permanent ^/docs/api-(.*) /docs/$1
 
 ### Redirects to Apache Nightlies, this will change when they have a separate area for released artifacts
 Redirect temp /charts https://nightlies.apache.org/solr/release/helm-charts
-RewriteRule ^operator/downloads/?$  operator/downloads.html [PT]
+Redirect temp /operator/downloads/crds https://nightlies.apache.org/solr/release/operator/crds

Review comment:
       I would just need to modify the digits pattern for the version number a bit, but I will do this anyways.

##########
File path: themes/solr/templates/htaccess.template
##########
@@ -71,7 +71,7 @@ RedirectMatch Permanent ^/docs/api-(.*) /docs/$1
 
 ### Redirects to Apache Nightlies, this will change when they have a separate area for released artifacts
 Redirect temp /charts https://nightlies.apache.org/solr/release/helm-charts
-RewriteRule ^operator/downloads/?$  operator/downloads.html [PT]
+Redirect temp /operator/downloads/crds https://nightlies.apache.org/solr/release/operator/crds

Review comment:
       At a later stage, we can remove this line and add the "/operator/dowloads/crds" prefix to the regex for the Subversion rewrite.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr-site] HoustonPutman commented on a change in pull request #35: Rename operator downloads page to artifacts.

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #35:
URL: https://github.com/apache/solr-site/pull/35#discussion_r697558113



##########
File path: themes/solr/templates/htaccess.template
##########
@@ -71,7 +71,7 @@ RedirectMatch Permanent ^/docs/api-(.*) /docs/$1
 
 ### Redirects to Apache Nightlies, this will change when they have a separate area for released artifacts
 Redirect temp /charts https://nightlies.apache.org/solr/release/helm-charts
-RewriteRule ^operator/downloads/?$  operator/downloads.html [PT]
+Redirect temp /operator/downloads/crds https://nightlies.apache.org/solr/release/operator/crds

Review comment:
       Yes that would be great.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr-site] HoustonPutman commented on pull request #35: Rename operator downloads page to artifacts.

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #35:
URL: https://github.com/apache/solr-site/pull/35#issuecomment-906744340


   Ok confirmed locally that this works with the redirect that we have in place currently (and removing the extra htaccess file).
   
   Will go ahead and fix the solr-operator documentation to prepare for this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr-site] HoustonPutman commented on pull request #35: Rename operator downloads page to artifacts.

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #35:
URL: https://github.com/apache/solr-site/pull/35#issuecomment-907324899


   So I actually like the new name of the page, since most people won't ever be "downloading" it really. 
   
   I'll go ahead and commit this, and let you carry on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr-site] HoustonPutman merged pull request #35: Rename operator downloads page to artifacts.

Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #35:
URL: https://github.com/apache/solr-site/pull/35


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org